Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two missing states for RDS cluster update #21072

Closed

Conversation

Kdecherf
Copy link
Contributor

@Kdecherf Kdecherf commented Sep 28, 2021

Superceded by #17111

Enabling/disabling IAM auth on an existing RDS cluster led to a fail of
terraform apply as 'configuring-iam-database-auth' was not an expected pending
state.

I also identified another missing pending state: 'renaming'.

This is my first PR ever on a terraform-related project, if things are missing in my PR please let me know.

As I'm not confident with the test codebase, I'm not sure if there is a specific test case to update or add for what I'm changing.

Here is a snippet to reproduce the issue, set iam_database_authentication_enabled to true after the initial creation:

terraform {
  required_providers {
    aws = {
      source = "hashicorp/aws"
    }
  }
  required_version = ">= 0.13"
}

provider "aws" {
  region = "eu-west-1"
}

resource "aws_rds_cluster" "cluster" {
  cluster_identifier = "cluster-test"

  engine = "aurora-postgresql"
  engine_version = "11.6"
  deletion_protection = false
  backup_retention_period = 1
  skip_final_snapshot = true
  master_username = "root"
  master_password = "whatever"
  apply_immediately = true

  iam_database_authentication_enabled = false
}

resource "aws_rds_cluster_instance" "instance" {
  cluster_identifier = aws_rds_cluster.cluster.id
  identifier = "cluster-test-instance"
  instance_class = "db.t3.medium"
  engine = "aurora-postgresql"
  engine_version = "11.6"
}

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Enabling/disabling IAM auth on an existing RDS cluster led to a fail of
terraform as 'configuring-iam-database-auth' was not an expected pending
state.

I also identified another missing pending state: 'renaming'.

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels Sep 28, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Kdecherf 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 28, 2021
@YakDriver YakDriver self-assigned this Oct 13, 2021
@YakDriver
Copy link
Member

Thank you for your work on this! Your commits were included with #17111. Of course, you still receive credit for them.

@github-actions github-actions bot added this to the v3.63.0 milestone Oct 13, 2021
@Kdecherf Kdecherf deleted the f-rds_cluster_pending_states branch October 14, 2021 08:03
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants