provider: Replace validateRFC3339TimeString usage with upstream validation.ValidateRFC3339TimeString #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
the
technical-debt
ghost
added
size/M
joestump
approved these changes
Oct 15, 2018
…ation.ValidateRFC3339TimeString
bflad
force-pushed
the
td-validateRFC3339TimeString
branch
from
ddf5108
to
c8aae5d
Compare
paddycarver
approved these changes
Oct 16, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was merged upstream and is already in use in
aws_appsync_api_keyandaws_launch_template. 😄Changes proposed in this pull request:
validateRFC3339TimeStringusage with upstreamvalidation.ValidateRFC3339TimeStringvalidateRFC3339TimeStringimplementation and testing in this projectOutput from acceptance testing: Can provide if necessary