Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor some validators #6183

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Refactor some validators #6183

merged 4 commits into from
Oct 17, 2018

Conversation

ewbankkit
Copy link
Contributor

Fixes #6147.
Similar to #6156.

@ghost ghost added service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/databasemigrationservice service/ecr Issues and PRs that pertain to the ecr service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/emr Issues and PRs that pertain to the emr service. service/firehose Issues and PRs that pertain to the firehose service. service/glacier Issues and PRs that pertain to the glacier service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. size/L Managed by automation to categorize the size of a PR. service/organizations Issues and PRs that pertain to the organizations service. service/s3 Issues and PRs that pertain to the s3 service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 17, 2018
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Oct 17, 2018
@bflad bflad added this to the v1.41.0 milestone Oct 17, 2018
bflad
bflad approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks so much, @ewbankkit! 🚀

@bflad bflad merged commit 20151d7 into hashicorp:master Oct 17, 2018
@ewbankkit ewbankkit deleted the issue-6147 branch October 17, 2018 21:13
@ewbankkit ewbankkit mentioned this pull request Mar 12, 2019
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/ecr Issues and PRs that pertain to the ecr service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/emr Issues and PRs that pertain to the emr service. service/firehose Issues and PRs that pertain to the firehose service. service/glacier Issues and PRs that pertain to the glacier service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/organizations Issues and PRs that pertain to the organizations service. service/s3 Issues and PRs that pertain to the s3 service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.41.0
Development

Successfully merging this pull request may close these issues.

Refactor some validators
2 participants
@ewbankkit @bflad