Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iot_dps - fix update of old resource without data_residency_enabled #20632

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Feb 23, 2023

Fix #20587
azurerm_iot_dps created with early provider version doesn't have property data_residency_enabled set, which cannot be set (even to its default value) any more. Fixing the issue by splitting the Create/Update, and use the existing iotdps in the update call (data_residency_enabled is ForceNew so no need to operate it in Update)

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Feb 23, 2023

Test result
image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @myc2h6o LGTM 🫐

@stephybun stephybun added the bug label Feb 23, 2023
@stephybun stephybun merged commit 86b5163 into hashicorp:main Feb 23, 2023
@github-actions github-actions bot added this to the v3.45.0 milestone Feb 23, 2023
stephybun added a commit that referenced this pull request Feb 23, 2023
@myc2h6o myc2h6o deleted the iotdps_update_fix branch February 24, 2023 02:13
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating azurerm_iothub_dps fails
2 participants