Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_maintenance_assignment_virtual_machine - maintenance configuration is now obtained by name rather than using the first in the list #20766

Merged
merged 6 commits into from
Mar 7, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Mar 3, 2023

fixes #20705

Currently TF always set maintenance_configuration_id with the first one of maintenance configuration in the list when one vm is linked by two maintenance configurations. So TF would cause diff after first apply. I assume we should check and set maintenance_configuration_id by the name of maintenance configuration list.

And I found seems TF only checks if the vm is linked maintenance configuration while checking if azurerm_maintenance_assignment_virtual_machine exists. If such, one vm cannot be linked again per current TF behavior. So I assume it's unexpected. Per my undestanding, we should check the name of maintenance configuration in the list to see if the resource exists.

image

@github-actions github-actions bot added size/M and removed size/S labels Mar 3, 2023
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title azurerm_maintenance_assignment_virtual_machine - get maintenance configuration per it's name azurerm_maintenance_assignment_virtual_machine - maintenance configuration is now obtained by name rather than using the first in the list Mar 7, 2023
@mbfrahry mbfrahry added this to the v3.47.0 milestone Mar 7, 2023
@mbfrahry mbfrahry merged commit e87d66f into hashicorp:main Mar 7, 2023
mbfrahry added a commit that referenced this pull request Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants