Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_windows_web_app - fix incorrect warning message caused by trying to get the wrong entity #25214

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Mar 12, 2024

When checking the presence of the app service environment, we need to check the ase entity, not the web app entity.

fix #25204

@xiaxyi xiaxyi changed the title azurerm_windows_web_app - fix bugs caused by getting the wrong entity azurerm_windows_web_app - fix incorrect warning message caused by trying to get the wrong entity Mar 12, 2024
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaxyi - LGTM 👍

@jackofallops jackofallops merged commit dec903f into hashicorp:main Mar 12, 2024
29 checks passed
@github-actions github-actions bot added this to the v3.96.0 milestone Mar 12, 2024
jackofallops added a commit that referenced this pull request Mar 12, 2024
dduportal referenced this pull request in jenkins-infra/azure Mar 18, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.95.0&#34; to &#34;3.96.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.96.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.96.0&#xA;ENHANCEMENTS:&#xD;&#xA;&#xD;&#xA;*
dependencies: updating to `v0.20240314.1083835` of
`github.com/hashicorp/go-azure-sdk`
([#25255](https://github.com/hashicorp/terraform-provider-azurerm/issues/25255))&#xD;&#xA;*
dependencies: updating to `v0.25.1` of
`github.com/tombuildsstuff/giovanni`
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
dependencies: updating to `v1.33.0` of `google.golang.org/protobuf`
([#25243](https://github.com/hashicorp/terraform-provider-azurerm/issues/25243))&#xD;&#xA;*
`storage`: updating the data plane resources to use the transport layer
from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
Data Source: `azurerm_storage_table_entities` - support for AAD
authentication
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
Data Source: `azurerm_storage_table_entity` - support for AAD
authentication
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_kusto_cluster` - support `None` pattern for the
`virtual_network_configuration` block
([#24733](https://github.com/hashicorp/terraform-provider-azurerm/issues/24733))&#xD;&#xA;*
`azurerm_linux_function_app` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_linux_function_app_slot` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_stack_hci_cluster` - support the `identity`, `cloud_id`,
`service_endpoint` and `resource_provider_object_id` properties
[GH-25031]&#xD;&#xA;* `azurerm_storage_share_file` - support for AAD
authentication
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_storage_share_directory` - support for AAD authentication,
deprecate `share_name` and `storage_account_name` in favor of
`storage_share_id`
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_storage_table_entity` - support for AAD authentication,
deprecate `share_name` and `storage_account_name` in favor of
`storage_table_id`
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_storage_table_entity` - support for AAD authentication
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_windows_function_app` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_windows_function_app_slot` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_windows_web_app` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_windows_web_app_slot` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;&#xD;&#xA;BUG
FIXES:&#xD;&#xA;&#xD;&#xA;* `azurerm_container_app_custom_domain` - fix
resource ID parsing bug preventing import
([#25192](https://github.com/hashicorp/terraform-provider-azurerm/issues/25192))&#xD;&#xA;*
`azurerm_windows_web_app` - fix incorrect warning message when checking
name availability
([#25214](https://github.com/hashicorp/terraform-provider-azurerm/issues/25214))&#xD;&#xA;*
`azurerm_virtual_machine_run_command` - prevent a bug during updates
([#25186](https://github.com/hashicorp/terraform-provider-azurerm/issues/25186))&#xD;&#xA;*
Data Source: `azurerm_storage_table_entities` - Fix `items.x.properties`
truncating to one entry
([#25211](https://github.com/hashicorp/terraform-provider-azurerm/issues/25211))</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/52/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding webapp to ASEv3 gives incorrect warning
2 participants