Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switching to use ID Formatters #14410

Merged
merged 29 commits into from
Dec 1, 2021
Merged

refactor: switching to use ID Formatters #14410

merged 29 commits into from
Dec 1, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR continues working through switching packages over to using ID Formatters

tombuildsstuff and others added 28 commits November 30, 2021 15:48
@tombuildsstuff
r/logic_app_standard: refactoring to use an id parser
2be475a
@tombuildsstuff
d/firewall: switching to use a resource id formatter
5bc04e6
@tombuildsstuff
r/mariadb_server: refactoring to use an id formatter
16bc046
@tombuildsstuff
d/servicebus_namespace_disaster_recovery_config: refactoring to use a…
817669a 
…n id formatter
@tombuildsstuff
d/recovery_services_vault: switching to use an id formatter
cbf31d0
@tombuildsstuff
d/synapse_workspace: refactoring to use an id formatter
70bb4b0
@tombuildsstuff
d/subscription: updating to use a Resource ID Formatter
ffa240d
@tombuildsstuff
d/traffic_manager_geographical_location: adding a note about the use …
f8dae7d 
…of the id
@tombuildsstuff
d/mariadb_server: refactoring to use an id formatter
35d6824
@tombuildsstuff
r/mysql_server_key: refactoring to use an id formatter
a820398
@tombuildsstuff
r/management_lock: switching to use a nextgen ID parser/formatter
31ac987
@tombuildsstuff
resourcegroups: adding a disclaimer about why these are being left fo…
36f3e49 
…r the moment

This will require both a state migration and details in the changelog, so this'll
need to be done last
@tombuildsstuff
resource: generating insensitive parsers for resource group template …
490ba5a 
…deployment id's
@tombuildsstuff
r/template_deployment: adding a state migration for the legacy templa…
16ca4d0 
…te deployment resource
@tombuildsstuff
r/stream_analytics_output_servicebus_queue: switching to use an id fo…
5475b40 
…rmatter
@tombuildsstuff
r/stream_analytics_output_mssql: refactoring to use an id formatter
3297b8e
@tombuildsstuff
r/stream_analytics_output_eventhub: refactoring to use an id formatter
47ba5c8
@tombuildsstuff
d/stream_analytics_job: switching to use an id formatter
8cca988
@tombuildsstuff
r/stream_analytics_output_blob: switching to use an id formatter
c6307b7
@mbfrahry
Automation: finalize id parsers
17e7ced
@mbfrahry
Merge branch 'r/resource-ids-2' of https://github.com/terraform-provi…
f51dbf3 
…ders/terraform-provider-azurerm into r/resource-ids-2
@tombuildsstuff
r/stream_analytics_function_javascript_udf: refactoring to use an id …
330bd95 
…formatter
@tombuildsstuff
Merge branch 'r/resource-ids-2' of github.com:hashicorp/terraform-pro…
880578f 
…vider-azurerm into r/resource-ids-2
@tombuildsstuff
d/netapp_volume: refactoring to use an id formatter
c96491b
@tombuildsstuff
d/netapp_account: refactoring to use an id formatter
31ae3bf
@tombuildsstuff
d/netapp_pool: refactoring to use an id formatter
531d038
@tombuildsstuff
r/netapp_snapshot: refactoring to use an id formatter
1f116a2
@tombuildsstuff
d/netapp_snapshot: refactoring to use an id formatter
9c9884a
@tombuildsstuff tombuildsstuff added this to the v2.88.0 milestone Dec 1, 2021
@tombuildsstuff tombuildsstuff requested a review from a team December 1, 2021 01:18
katbyte
katbyte approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@tombuildsstuff tombuildsstuff merged commit d65781d into main Dec 1, 2021
@tombuildsstuff tombuildsstuff deleted the r/resource-ids-2 branch December 1, 2021 15:49
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v2.88.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
refactor size/XL
Projects
None yet
Milestone
v2.88.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tombuildsstuff @katbyte @mbfrahry