new resource:`azurerm_application_load_balancer_subnet_association` #23628

ziyeqf · 2023-10-20T05:51:22Z

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

magodo

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

internal/services/servicenetworking/application_load_balancer_association_resource_test.go

internal/services/servicenetworking/application_load_balancer_association_resource.go

magodo · 2023-10-20T09:04:00Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+						Id: config.SubnetId,
+					},
+					AssociationType: associationsinterface.AssociationTypeSubnets,
+				},


Suggested change

},

Tags: tags.FromTypedObject(config.Tags),

},

I cant use it because it returns map[string]*string, while sdk needs *map[string]string

There's two imports for tags - the legacy one within this provider (./internal/tags) and the one within go-azure-helpers (github.com/hashicorp/go-azure-helpers/resourcemanager/tags) - updating the reference to use go-azure-helpers should solve that?

please follow toms advice here @ziyeqf

I'm already using "github.com/hashicorp/go-azure-helpers/resourcemanager/tags" now, is it correct?

internal/services/servicenetworking/application_load_balancer_association_resource.go

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

magodo

Thanks for this PR!
I have left some additional mostly minor comments that once addressed this should be good to merge 👍

magodo · 2023-10-24T05:08:03Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+	"github.com/hashicorp/terraform-provider-azurerm/internal/tf/validation"
+)
+
+type AssociationResource struct{}


Can we rename it something like ApplicationLoadBalancerAssociationResource or even ApplicationLoadBalancerAssociationSubnetResource to be more specific?

internal/services/servicenetworking/application_load_balancer_association_resource.go

magodo · 2023-10-24T05:12:30Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+			}
+
+			if controller.Model != nil {
+				association.Location = location.Normalize(controller.Model.Location)


Is the location here required as it typically should be the same as its parent resource? If that is the case, then we can fail early (prior to sending the requset) with telling the user that the required location from the parent model is not retrieved.

internal/services/servicenetworking/application_load_balancer_association_resource_test.go

magodo · 2023-10-24T05:23:50Z

website/docs/r/application_load_balancer_association.html.markdown

+
+* `subnet_id` - (Required) The ID of the subnet which the Application Gateway for Containers associated to. Changing this forces a new resource to be created.
+
+**Note:** The subnet should be delegated by `Microsoft.ServiceNetworking/trafficControllers` as the example. 


Suggested change

**Note:** The subnet should be delegated by `Microsoft.ServiceNetworking/trafficControllers` as the example.

**Note:** The subnet to be used must be have a delegation for `Microsoft.ServiceNetworking/trafficControllers` as shown in the example above.

website/docs/r/application_load_balancer_association.html.markdown

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

tombuildsstuff

hey @ziyeqf

Thanks for this PR - I've left some comments inline, but if we can fix those up then we should be able to take another look 👍

Thanks!

tombuildsstuff · 2023-10-23T11:32:32Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+		"application_load_balancer_id": {
+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			ForceNew:     true,
+			ValidateFunc: associationsinterface.ValidateTrafficControllerID,
+		},


FWIW the commonschema package has a ResourceIDReference schema property for this purpose:

Suggested change

"application_load_balancer_id": {

Type: pluginsdk.TypeString,

Required: true,

ForceNew: true,

ValidateFunc: associationsinterface.ValidateTrafficControllerID,

},

"application_load_balancer_id": commonschema.ResourceIDReferenceForceNew(associationsinterface.TrafficControllerId{}),

tombuildsstuff · 2023-10-23T11:32:57Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+		"subnet_id": {
+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			ForceNew:     true,
+			ValidateFunc: commonids.ValidateSubnetID,
+		},


(same here)

Suggested change

"subnet_id": {

Type: pluginsdk.TypeString,

Required: true,

ForceNew: true,

ValidateFunc: commonids.ValidateSubnetID,

},

"subnet_id": commonschema.ResourceIDReferenceForceNew(commonids.SubnetId{}),

tombuildsstuff · 2023-10-23T11:33:17Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+
+type AssociationResource struct{}
+
+type AssociationModel struct {


Since this is specific to the Resource, can we make this:

Suggested change

type AssociationModel struct {

type AssociationResourceModel struct {

tombuildsstuff · 2023-10-23T11:35:45Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+						Id: config.SubnetId,
+					},
+					AssociationType: associationsinterface.AssociationTypeSubnets,
+				},


There's two imports for tags - the legacy one within this provider (./internal/tags) and the one within go-azure-helpers (github.com/hashicorp/go-azure-helpers/resourcemanager/tags) - updating the reference to use go-azure-helpers should solve that?

tombuildsstuff · 2023-10-23T11:36:00Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+
+			controller, err := trafficControllerClient.Get(ctx, *albId)
+			if err != nil {
+				return fmt.Errorf("retrieving %s: %+v", *albId, err)


Suggested change

return fmt.Errorf("retrieving %s: %+v", *albId, err)

return fmt.Errorf("retrieving parent %s: %+v", *albId, err)

tombuildsstuff · 2023-10-25T15:42:17Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+			if len(config.Tags) > 0 {
+				association.Tags = &config.Tags
+			}


we should always be setting tags here, else you can't remove them?

tombuildsstuff · 2023-10-25T15:42:27Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+				return fmt.Errorf("retrieving %s: model was nil", *albId)
+			}
+
+			association.Location = location.Normalize(controller.Model.Location)


this can be inlined above

tombuildsstuff · 2023-10-25T15:42:45Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+
+				if prop := model.Properties; prop != nil {
+					if prop.Subnet != nil {
+						parsedSubnetId, err := commonids.ParseSubnetID(prop.Subnet.Id)


When parsing IDs in the Read we need to parse these insensitively:

Suggested change

parsedSubnetId, err := commonids.ParseSubnetID(prop.Subnet.Id)

parsedSubnetId, err := commonids.ParseSubnetIDInsensitively(prop.Subnet.Id)

tombuildsstuff · 2023-10-25T15:43:44Z

internal/services/servicenetworking/application_load_balancer_association_resource_test.go

+		if response.WasNotFound(resp.HttpResponse) {
+			return pointer.To(false), nil
+		}
+		return nil, fmt.Errorf("while checking existence for %q: %+v", id.String(), err)


Suggested change

return nil, fmt.Errorf("while checking existence for %q: %+v", id.String(), err)

return nil, fmt.Errorf("while checking existence of %s: %+v", *id, err)

tombuildsstuff · 2023-10-25T15:44:43Z

website/docs/r/application_load_balancer_association.html.markdown

+# azurerm_application_load_balancer_association
+
+Manages an Application Gateway for Containers Association.


since this is a Subnet association, this resource probably should be _subnet_association?

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

ziyeqf · 2023-10-26T06:02:20Z

Have updated code except the naming, as the service team is concern about the naming. ~~once get a reply, will update the naming.~~

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

tgolly · 2023-11-02T05:20:36Z

website/docs/r/application_load_balancer_association.html.markdown

+resource "azurerm_application_load_balancer_subnet_association" "example" {
+  name                         = "example"
+  application_load_balancer_id = azurerm_application_load_balancer.example.id
+  subnet_id                    = azurerm_subnet_example.id


Suggested change

subnet_id = azurerm_subnet_example.id

subnet_id = azurerm_subnet.example.id

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

ziyeqf · 2023-11-07T07:06:26Z

kindly ping this pr is ready for another look with the name has been changed

katbyte · 2023-11-10T01:04:56Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

@@ -0,0 +1,214 @@
+package servicenetworking


This filename needs to be updated to reflect the new name?

katbyte · 2023-11-10T01:05:12Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+	"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
+)
+
+type ApplicationLoadBalancerAssociationResource struct{}


as do all these types?

Suggested change

type ApplicationLoadBalancerAssociationResource struct{}

type ApplicationLoadBalancerSubnetAssociationResource struct{}

katbyte · 2023-11-10T01:05:19Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+	}
+}
+
+func (t ApplicationLoadBalancerAssociationResource) Attributes() map[string]*pluginsdk.Schema {


katbyte · 2023-11-10T01:05:36Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+			controller, err := trafficControllerClient.Get(ctx, *albId)
+			if err != nil {
+				return fmt.Errorf("retrieving %s: %+v", *albId, err)
+			}


@ziyeqf could you address this comment?

katbyte · 2023-11-10T01:06:11Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+						Id: config.SubnetId,
+					},
+					AssociationType: associationsinterface.AssociationTypeSubnets,
+				},


please follow toms advice here @ziyeqf

katbyte · 2023-11-10T01:06:55Z

internal/services/servicenetworking/application_load_balancer_association_resource.go

+				return fmt.Errorf("parsing id %v", err)
+			}
+
+			// Thought `AssociationSubnetUpdate` defined in the SDK contains the `subnetId`, while per testing it can not be updated


@ziyeqf - have you opened an issue yet? could you add it to this comment? and address the question?

katbyte · 2023-11-10T01:07:08Z

internal/services/servicenetworking/application_load_balancer_association_resource_test.go

+	return pointer.To(resp.Model != nil), nil
+}
+
+func TestAccApplicationLoadBalancerAssociation_basic(t *testing.T) {


test names nee to be updated too?

katbyte · 2023-11-10T01:07:19Z

internal/services/servicenetworking/validate/application_load_balancer_association_name.go

@@ -0,0 +1,14 @@
+package validate


and this file name?

katbyte · 2023-11-10T01:07:49Z

website/docs/r/application_load_balancer_association.html.markdown

@@ -0,0 +1,94 @@
+---


and this file name?

jackofallops

Thanks for the changes @ziyeqf.
Just one more thing to address and I think this will be good to merge.
Additionally, there's a problem in the requiresImport test for the parent resource, I think there's an extra provider block in the import config func that needs to be removed if you can take a look at that also?

Thanks!

Edit: Apologies, apparently I already had another partial review that has already been addressed, just the validate section I think to still look at.

internal/services/servicenetworking/application_load_balancer_association_resource.go

internal/services/servicenetworking/application_load_balancer_association_resource_test.go

website/docs/r/application_load_balancer_association.html.markdown

jackofallops · 2023-11-17T11:22:15Z

...nal/services/servicenetworking/validate/application_load_balancer_subnet_association_name.go

+)
+
+func ApplicationLoadBalancerSubnetAssociationName() pluginsdk.SchemaValidateFunc {
+	return validation.StringMatch(regexp.MustCompile(`^[a-zA-Z0-9][a-zA-Z0-9_.-]{0,62}[a-zA-Z0-9]$`),


This regex is slightly incorrect for the description below, it won't allow a name of 1 character. Can we split this out into separate checks for the limitations to make it easier to maintain and report the correct violation to the users?

ziyeqf · 2023-11-22T14:52:40Z

kindly ping

jackofallops

Thanks for the changes @ziyeqf, this LGTM now 👍

jackofallops · 2023-11-22T15:18:50Z

Tests look good:

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.81.0" to "3.82.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.82.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.82.0
FEATURES:

* New Data Source: `azurerm_monitor_workspace` ([#23928](https://github.com/hashicorp/terraform-provider-azurerm/issues/23928))
* New Resource: `azurerm_application_load_balancer_subnet_association` ([#23628](https://github.com/hashicorp/terraform-provider-azurerm/issues/23628))

ENHANCEMENTS:

* dependencies: updating to `v0.20231117.1130141` of `github.com/hashicorp/go-azure-sdk` ([#23945](https://github.com/hashicorp/terraform-provider-azurerm/issues/23945))
* `azurestackhci`: updating to API Version `2023-08-01` ([#23939](https://github.com/hashicorp/terraform-provider-azurerm/issues/23939))
* `dashboard`: updating to API Version `2023-09-01` ([#23929](https://github.com/hashicorp/terraform-provider-azurerm/issues/23929))
* `hpccache`: updating to API version `2023-05-01` ([#24005](https://github.com/hashicorp/terraform-provider-azurerm/issues/24005))
* `mssql`: updating resources using `hashicorp/go-azure-sdk` to API Version `2023-02-01-preview` ([#23721](https://github.com/hashicorp/terraform-provider-azurerm/issues/23721))
* `templatespecversions`: updating to API Version `2022-02-01` ([#24007](https://github.com/hashicorp/terraform-provider-azurerm/issues/24007))
* Data Source: `azurerm_template_spec_version` - refactoring to use `hashicorp/go-azure-sdk` ([#24007](https://github.com/hashicorp/terraform-provider-azurerm/issues/24007))
* `azurerm_cosmosdb_postgresql_cluster` - `coordinator_storage_quota_in_mb` and `coordinator_vcore_count` are no longer required for read replicas ([#23928](https://github.com/hashicorp/terraform-provider-azurerm/issues/23928))
* `azurerm_dashboard_grafana` - `sku` can now be set to `Essential` ([#23934](https://github.com/hashicorp/terraform-provider-azurerm/issues/23934))
* `azurerm_gallery_application_version` - add support for the `config_file`, `package_file` and `target_region.exclude_from_latest` properties ([#23816](https://github.com/hashicorp/terraform-provider-azurerm/issues/23816))
* `azurerm_hdinsight_hadoop_cluster` - `script_actions` is no longer Force New ([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))
* `azurerm_hdinsight_hbase_cluster` - `script_actions` is no longer Force New ([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))
* `azurerm_hdinsight_interactive_query_cluster` - `script_actions` is no longer Force New ([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))
* `azurerm_hdinsight_kafka_cluster` - `script_actions` is no longer Force New ([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))
* `azurerm_hdinsight_spark_cluster` - `script_actions` is no longer Force New ([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))
* `azurerm_kubernetes_cluster` - add support for the `gpu_instance` property ([#23887](https://github.com/hashicorp/terraform-provider-azurerm/issues/23887))
* `azurerm_kubernetes_cluster_node_pool` - add support for the `gpu_instance` property ([#23887](https://github.com/hashicorp/terraform-provider-azurerm/issues/23887))
* `azurerm_log_analytics_workspace` - add support for the `identity` property ([#23864](https://github.com/hashicorp/terraform-provider-azurerm/issues/23864))
* `azurerm_linux_function_app` - add support for dotnet 8 ([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))
* `azurerm_linux_function_app_slot` - add support for dotnet 8 ([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))
* `azurerm_managed_lustre_file_system` - export attribute `mgs_address` ([#23942](https://github.com/hashicorp/terraform-provider-azurerm/issues/23942))
* `azurerm_mssql_database` - support for Hyperscale SKUs ([#23974](https://github.com/hashicorp/terraform-provider-azurerm/issues/23974))
* `azurerm_mssql_database` - refactoring to use `hashicorp/go-azure-sdk` ([#23721](https://github.com/hashicorp/terraform-provider-azurerm/issues/23721))
* `azurerm_mssql_server` - refactoring to use `hashicorp/go-azure-sdk` ([#23721](https://github.com/hashicorp/terraform-provider-azurerm/issues/23721))
* `azurerm_shared_image` - add support for `trusted_launch_supported` ([#23781](https://github.com/hashicorp/terraform-provider-azurerm/issues/23781))
* `azurerm_spring_cloud_container_deployment` - add support for the `application_performance_monitoring_ids` property ([#23862](https://github.com/hashicorp/terraform-provider-azurerm/issues/23862))
* `azurerm_spring_cloud_customized_accelerator` - add support for the `accelerator_type` and `path` properties ([#23797](https://github.com/hashicorp/terraform-provider-azurerm/issues/23797))
* `azurerm_point_to_site_vpn_gateway` - allow multiple `connection_configurations` blocks ([#23936](https://github.com/hashicorp/terraform-provider-azurerm/issues/23936))
* `azurerm_private_dns_cname_record` - `ttl` can now be set to 0 ([#23918](https://github.com/hashicorp/terraform-provider-azurerm/issues/23918))
* `azurerm_windows_function_app` - add support for dotnet 8 ([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))
* `azurerm_windows_function_app_slot` - add support for dotnet 8 ([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))

BUG FIXES:
* `azurerm_api_management` - correct a bug with additional location zones within the `additional_location` block ([#23943](https://github.com/hashicorp/terraform-provider-azurerm/issues/23943))
* `azurerm_dev_test_linux_virtual_machine` - `storage_type` is now ForceNew to match the updated API behaviour ([#23973](https://github.com/hashicorp/terraform-provider-azurerm/issues/23973))
* `azurerm_dev_test_windows_virtual_machine` - `storage_type` is now ForceNew to match the updated API behaviour ([#23973](https://github.com/hashicorp/terraform-provider-azurerm/issues/23973))
* `azurerm_disk_encryption_set` - resource will recreate if `identity` changes from `SystemAssigned` to `UserAssigned` ([#23904](https://github.com/hashicorp/terraform-provider-azurerm/issues/23904))
* `azurerm_eventhub_cluster`: `sku_name` is no longer ForceNew ([#24009](https://github.com/hashicorp/terraform-provider-azurerm/issues/24009))
* `azurerm_firewall` - recasing the value for `firewall_policy_id` to workaround the API returning the incorrect casing ([#23993](https://github.com/hashicorp/terraform-provider-azurerm/issues/23993))
* `azurerm_security_center_subscription_pricing` - fix a bug preventing removal of `extensions` and downgrading `tier` to `Free` ([#23821](https://github.com/hashicorp/terraform-provider-azurerm/issues/23821))
* `azurerm_windows_web_app` - fix an issue of incorrect application stack settings during update ([#23372](https://github.com/hashicorp/terraform-provider-azurerm/issues/23372))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/896/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-05-06T02:08:31Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation service/service-networking size/XL waiting-response labels Oct 20, 2023

ziyeqf force-pushed the tengzh/alb/association branch from a6191d2 to 98c786f Compare October 20, 2023 05:54

github-actions bot removed the waiting-response label Oct 20, 2023

new resource:azurerm_application_load_balancer_association

31e8553

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

ziyeqf force-pushed the tengzh/alb/association branch from 98c786f to 31e8553 Compare October 20, 2023 06:56

magodo requested changes Oct 20, 2023

View reviewed changes

github-actions bot added the waiting-response label Oct 20, 2023

update per comments

1a1cdfd

github-actions bot removed the waiting-response label Oct 20, 2023

typo

5674fea

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

ziyeqf force-pushed the tengzh/alb/association branch from 1e40f6e to 5674fea Compare October 20, 2023 09:31

ziyeqf requested a review from magodo October 20, 2023 09:38

github-actions bot added the waiting-response label Oct 23, 2023

update per comment

3407b4e

github-actions bot removed the waiting-response label Oct 23, 2023

This comment was marked as outdated.

Sign in to view

magodo marked this pull request as ready for review October 23, 2023 03:09

tombuildsstuff self-requested a review October 23, 2023 16:34

magodo requested changes Oct 24, 2023

View reviewed changes

github-actions bot added the waiting-response label Oct 24, 2023

update per comments

4d8b3c3

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

github-actions bot removed the waiting-response label Oct 24, 2023

tombuildsstuff suggested changes Oct 25, 2023

View reviewed changes

github-actions bot added the waiting-response label Oct 25, 2023

update per comments

a6ee143

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

github-actions bot removed the waiting-response label Oct 26, 2023

rename to azurerm_application_load_balancer_subnet_association

ab9fb63

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

ziyeqf changed the title ~~new resource:azurerm_application_load_balancer_association~~ new resource:azurerm_application_load_balancer_subnet_association Oct 26, 2023

tgolly reviewed Nov 2, 2023

View reviewed changes

typo

41d261e

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>

magodo mentioned this pull request Nov 3, 2023

azurerm_spring_cloud_customized_accelerator - use pandora sdk #23756

Merged

katbyte requested changes Nov 10, 2023

View reviewed changes

github-actions bot added the waiting-response label Nov 10, 2023

Update per comment

6db2907

github-actions bot removed the waiting-response label Nov 10, 2023

jackofallops requested changes Nov 17, 2023

View reviewed changes

github-actions bot added the waiting-response label Nov 17, 2023

update per comment

24ff0e0

github-actions bot removed the waiting-response label Nov 20, 2023

jackofallops approved these changes Nov 22, 2023

View reviewed changes

jackofallops merged commit a006ce2 into hashicorp:main Nov 22, 2023
23 checks passed

github-actions bot added this to the v3.82.0 milestone Nov 22, 2023

opentofu-provider-sync-service-account pushed a commit to opentofu/terraform-provider-azurerm that referenced this pull request Nov 22, 2023

Update CHANGELOG.md for hashicorp#23628

51975fb

neil-yechenwei mentioned this pull request Mar 8, 2024

New Data Source: azurerm_system_center_virtual_machine_manager_inventory_items #25110

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024


		* `subnet_id` - (Required) The ID of the subnet which the Application Gateway for Containers associated to. Changing this forces a new resource to be created.

		Note: The subnet should be delegated by `Microsoft.ServiceNetworking/trafficControllers` as the example.

	Note: The subnet should be delegated by `Microsoft.ServiceNetworking/trafficControllers` as the example.
	Note: The subnet to be used must be have a delegation for `Microsoft.ServiceNetworking/trafficControllers` as shown in the example above.


		type AssociationResource struct{}

		type AssociationModel struct {

	type AssociationModel struct {
	type AssociationResourceModel struct {

	return fmt.Errorf("retrieving %s: %+v", *albId, err)
	return fmt.Errorf("retrieving parent %s: %+v", *albId, err)

	parsedSubnetId, err := commonids.ParseSubnetID(prop.Subnet.Id)
	parsedSubnetId, err := commonids.ParseSubnetIDInsensitively(prop.Subnet.Id)

	return nil, fmt.Errorf("while checking existence for %q: %+v", id.String(), err)
	return nil, fmt.Errorf("while checking existence of %s: %+v", *id, err)

		# azurerm_application_load_balancer_association

		Manages an Application Gateway for Containers Association.

	subnet_id = azurerm_subnet_example.id
	subnet_id = azurerm_subnet.example.id

	type ApplicationLoadBalancerAssociationResource struct{}
	type ApplicationLoadBalancerSubnetAssociationResource struct{}

new resource:azurerm_application_load_balancer_subnet_association #23628

new resource:azurerm_application_load_balancer_subnet_association #23628

Conversation

ziyeqf commented Oct 20, 2023 • edited Loading

magodo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ziyeqf Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

This comment was marked as outdated.

magodo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ziyeqf commented Oct 26, 2023 • edited Loading

Choose a reason for hiding this comment

ziyeqf commented Nov 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackofallops left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ziyeqf commented Nov 22, 2023

jackofallops left a comment

Choose a reason for hiding this comment

jackofallops commented Nov 22, 2023

github-actions bot commented May 6, 2024

new resource:`azurerm_application_load_balancer_subnet_association` #23628

new resource:`azurerm_application_load_balancer_subnet_association` #23628

ziyeqf commented Oct 20, 2023 •

edited

Loading

ziyeqf Nov 10, 2023 •

edited

Loading

ziyeqf commented Oct 26, 2023 •

edited

Loading

jackofallops left a comment •

edited

Loading