New Data Source: `azurerm_system_center_virtual_machine_manager_inventory_items` #25110

neil-yechenwei · 2024-03-01T07:01:13Z

The System Center Virtual Machine Manager Cloud requires the uuid of the System Center Virtual Machine Manager Inventory Item that is assigned by System Center Virtual Machine Manager Server. So service team suggests us to implement Inventory Items List API to get the UUIDs of Inventory Items.

--- PASS: TestAccDataSourceSystemCenterVirtualMachineManagerInventoryItems_basic (297.48s)

References:
Azure doc
REST API specs

…ventory_item

…ory_items

ms-zhenhua

Hi @neil-yechenwei,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go

ms-zhenhua

@neil-yechenwei, thank you for your updates. LGTM~

stephybun

I have a couple of suggestions and questions, could you take a look at them please @neil-yechenwei? Thanks!

stephybun · 2024-03-07T10:09:23Z

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go

+				return err
+			}
+
+			scvmmServerId, err := inventoryitems.ParseVMmServerIDInsensitively(state.SystemCenterVirtualMachineManagerServerId)


Is there a specific reason we're parsing this insensitively?

Tom suggests to use insensitively. See more details from #23628 (comment).

This is coming from a user specified value rather than an API returned value - so should be case-sensitive.

stephybun · 2024-03-07T10:11:56Z

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go

+				return err
+			}
+
+			id := fmt.Sprintf("%s/inventoryItems", scvmmServerId.ID())


Why aren't we constructing this ID with inventoryitems.NewInventoryItemID()?

Reason 1: inventoryitems.NewInventoryItemID() points to the dependent Inventory Item resource and service team expects us to not expose it to users.

Reason 2: Setting inventoryitems.NewInventoryItemID() requires the specified Inventory Item Id but this data source is used to expose a list of Inventory Items. So I assume that we couldn't set it with any Inventory Item Id in the list.

We should not be defining Terraform specific Resource IDs where they aren't absolutely necessary - this is a great example of where we should be using the SCVMM Server ID rather than creating something random - can we update this as @stephybun mentions

Updated to use SCVMM Server ID.

stephybun · 2024-03-07T10:13:13Z

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go

+			if model := resp.Model; model != nil {
+				inventoryItems := flattenInventoryItems(model)
+				if len(inventoryItems) == 0 {
+					return fmt.Errorf("no inventory items were found for the System Center Virtual Machine Manager Server %q", scvmmServerId)


The string formatting of the ID already provides the relevant information

Suggested change

return fmt.Errorf("no inventory items were found for the System Center Virtual Machine Manager Server %q", scvmmServerId)

return fmt.Errorf("no inventory items were found for %s", scvmmServerId)

stephybun · 2024-03-07T10:15:21Z

website/docs/d/system_center_virtual_machine_manager_inventory_items.html.markdown

+
+* `id` - The ID of the System Center Virtual Machine Manager Inventory Items.
+
+* `inventory_items` - One or more `inventory_item` blocks as defined below.


The property name in the schema is inventory_items so that should be used everywhere

Suggested change

* `inventory_items` - One or more `inventory_item` blocks as defined below.

* `inventory_items` - One or more `inventory_items` blocks as defined below.

stephybun · 2024-03-07T10:15:29Z

website/docs/d/system_center_virtual_machine_manager_inventory_items.html.markdown

+
+---
+
+A `inventory_item` block exports the following:


Suggested change

A `inventory_item` block exports the following:

A `inventory_items` block exports the following:

neil-yechenwei · 2024-03-08T02:51:16Z

@stephybun , thanks for the comments. I updated PR. Please take another look. Thanks.

katbyte

test failure:

------- Stdout: -------
=== RUN   TestAccDataSourceSystemCenterVirtualMachineManagerInventoryItems_basic
=== PAUSE TestAccDataSourceSystemCenterVirtualMachineManagerInventoryItems_basic
=== CONT  TestAccDataSourceSystemCenterVirtualMachineManagerInventoryItems_basic
    testcase.go:113: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: parsing "": cannot parse an empty string
        
          with azurerm_system_center_virtual_machine_manager_server.test,
          on terraform_plugin_test.tf line 37, in resource "azurerm_system_center_virtual_machine_manager_server" "test":
          37:   custom_location_id  = ""
        
        
        Error: expected "fqdn" to not be an empty string, got 
        
          with azurerm_system_center_virtual_machine_manager_server.test,
          on terraform_plugin_test.tf line 38, in resource "azurerm_system_center_virtual_machine_manager_server" "test":
          38:   fqdn                = ""
        
        
        Error: expected "username" to not be an empty string, got 
        
          with azurerm_system_center_virtual_machine_manager_server.test,
          on terraform_plugin_test.tf line 39, in resource "azurerm_system_center_virtual_machine_manager_server" "test":
          39:   username            = ""
        
        
        Error: expected "password" to not be an empty string, got 
        
          with azurerm_system_center_virtual_machine_manager_server.test,
          on terraform_plugin_test.tf line 40, in resource "azurerm_system_center_virtual_machine_manager_server" "test":
          40:   password            = ""
        
--- FAIL: TestAccDataSourceSystemCenterVirtualMachineManagerInventoryItems_basic (3.09s)
FAIL

neil-yechenwei · 2024-03-12T03:33:40Z

@katbyte , the PR is updated. Please take another look. Thanks. Below is the test result I just now triggered.

--- PASS: TestAccDataSourceSystemCenterVirtualMachineManagerInventoryItems_basic (240.62s)

tombuildsstuff

Left some comments inline, but I suspect for this Data Source to be useful given the number of items that could be returned, that we'll want some filter options here?

tombuildsstuff · 2024-03-12T16:53:13Z

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go

+	id            string `tfschema:"id"`
+	name          string `tfschema:"name"`


neither of these two fields is exported, so would need to be to be set into the state

I have already exposed them.

New Data Source: azurerm_system_center_virtual_machine_manager_inventory_items by neil-yechenwei · Pull Request #25110 · hashicorp/terraform-provider-azurerm (github.com)

New Data Source: azurerm_system_center_virtual_machine_manager_inventory_items by neil-yechenwei · Pull Request #25110 · hashicorp/terraform-provider-azurerm (github.com)

tombuildsstuff · 2024-03-12T16:53:48Z

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go

+				return err
+			}
+
+			scvmmServerId, err := inventoryitems.ParseVMmServerIDInsensitively(state.SystemCenterVirtualMachineManagerServerId)


This is coming from a user specified value rather than an API returned value - so should be case-sensitive.

tombuildsstuff · 2024-03-12T16:54:38Z

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go

+				return err
+			}
+
+			id := fmt.Sprintf("%s/inventoryItems", scvmmServerId.ID())


We should not be defining Terraform specific Resource IDs where they aren't absolutely necessary - this is a great example of where we should be using the SCVMM Server ID rather than creating something random - can we update this as @stephybun mentions

tombuildsstuff · 2024-03-12T16:55:37Z

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go

+			if v, ok := props.(inventoryitems.CloudInventoryItem); ok {
+				inventoryItem.name = pointer.From(v.InventoryItemName)
+				inventoryItem.Uuid = pointer.From(v.Uuid)
+				inventoryItem.InventoryType = string(inventoryitems.InventoryTypeCloud)
+			} else if v, ok := props.(inventoryitems.VirtualMachineInventoryItem); ok {
+				inventoryItem.name = pointer.From(v.InventoryItemName)
+				inventoryItem.Uuid = pointer.From(v.Uuid)
+				inventoryItem.InventoryType = string(inventoryitems.InventoryTypeVirtualMachine)
+			} else if v, ok := props.(inventoryitems.VirtualMachineTemplateInventoryItem); ok {
+				inventoryItem.name = pointer.From(v.InventoryItemName)
+				inventoryItem.Uuid = pointer.From(v.Uuid)
+				inventoryItem.InventoryType = string(inventoryitems.InventoryTypeVirtualMachineTemplate)
+			} else if v, ok := props.(inventoryitems.VirtualNetworkInventoryItem); ok {
+				inventoryItem.name = pointer.From(v.InventoryItemName)
+				inventoryItem.Uuid = pointer.From(v.Uuid)
+				inventoryItem.InventoryType = string(inventoryitems.InventoryTypeVirtualNetwork)
+			}


Given the number of items that could be returned here, this isn't going to be particularly usable.

Perhaps it'd be sensible to add a Name and Type filter to this resource, to obtain an Item rather than a list of Items, to make this more useful?

The Inventory Items are automatically created by the service while creating System Center Virtual Machine Manager. Service team confirmed that the end users can't create the Inventory Items. So the users don't know the "Name" of the Inventory Item when getting an specific Inventory Item. Hence, I made this data source to get a list of Inventory Items.

But seems it makes sense to add a filter "Inventory Type". So I updated PR to add a filter "Inventory Type" to get a list of the inventory items by the "Inventory Type".

neil-yechenwei · 2024-03-13T03:35:52Z

@tombuildsstuff , thanks for the comments. I updated PR. Please take another look. Thanks.

--- PASS: TestAccDataSourceSystemCenterVirtualMachineManagerInventoryItems_basic (291.44s)

katbyte

LGTM 🚂

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.97.1" to "3.98.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.98.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.98.0
FEATURES:

* New Resource: `azurerm_static_web_app_function_app_registration` ([#25331](https://github.com/hashicorp/terraform-provider-azurerm/issues/25331))
* New Resource: `azurerm_system_center_virtual_machine_manager_inventory_items` ([#25110](https://github.com/hashicorp/terraform-provider-azurerm/issues/25110))
* New Resource: `azurerm_workloads_sap_discovery_virtual_instance` ([#24342](https://github.com/hashicorp/terraform-provider-azurerm/issues/24342))
* New Resource: `azurerm_redis_cache_policy` ([#25477](https://github.com/hashicorp/terraform-provider-azurerm/issues/25477))
* New Resource: `azurerm_redis_cache_policy_assignment` ([#25477](https://github.com/hashicorp/terraform-provider-azurerm/issues/25477))

ENHANCEMENTS:

* dependencies: updating to `v0.20240402.1085733` of `github.com/hashicorp/go-azure-sdk` ([#25482](https://github.com/hashicorp/terraform-provider-azurerm/issues/25482))
* dependencies: updating to `v0.67.0` of `github.com/hashicorp/go-azure-helpers` ([#25446](https://github.com/hashicorp/terraform-provider-azurerm/issues/25446))
* dependencies: updating to `v0.25.4` of `github.com/tombuildsstuff/giovanni` ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `alertsmanagement` - updating remaining resources to use `hashicorp/go-azure-sdk` ([#25486](https://github.com/hashicorp/terraform-provider-azurerm/issues/25486))
* `applicationinsights` - updating remaining resources to use `hashicorp/go-azure-sdk` ([#25376](https://github.com/hashicorp/terraform-provider-azurerm/issues/25376))
* `compute` - update to API version `2024-03-01` ([#25436](https://github.com/hashicorp/terraform-provider-azurerm/issues/25436))
* `compute` - update shared image resources and data sources to use `hashicorp/go-azure-sdk` ([#25503](https://github.com/hashicorp/terraform-provider-azurerm/issues/25503))
* `containerinstance` - update to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#25416](https://github.com/hashicorp/terraform-provider-azurerm/issues/25416))
* `maintenance` - updating to API Version `2023-04-01` ([#25388](https://github.com/hashicorp/terraform-provider-azurerm/issues/25388))
* `recovery_services` - Add `recovery_service` block to the provider that supports `vm_backup_stop_protection_and_retain_data_on_destroy` and `purge_protected_items_from_vault_on_destroy`([#25515](https://github.com/hashicorp/terraform-provider-azurerm/issues/25515))
* `storage` - the Storage Account cache is now populated using `hashicorp/go-azure-sdk` ([#25437](https://github.com/hashicorp/terraform-provider-azurerm/issues/25437))
* `azurerm_bot_service_azure_bot` - support for the `cmk_key_vault_key_url` property ([#23640](https://github.com/hashicorp/terraform-provider-azurerm/issues/23640))
* `azurerm_capacity_reservation` - update validation for `capacity` ([#25471](https://github.com/hashicorp/terraform-provider-azurerm/issues/25471))
* `azurerm_container_app` - add support for `key_vault_id` and `identity` properties in the `secret` block ([#24773](https://github.com/hashicorp/terraform-provider-azurerm/issues/24773))
* `azurerm_databricks_workspace` - expose `managed_services_cmk_key_vault_id` and `managed_disk_cmk_key_vault_id and key_vault_id` to support cross subscription CMK's. ([#25091](https://github.com/hashicorp/terraform-provider-azurerm/issues/25091))
* `azurerm_databricks_workspace_root_dbfs_customer_managed_key` - expose `key_vault_id` to support cross subscription CMK's. ([#25091](https://github.com/hashicorp/terraform-provider-azurerm/issues/25091))
* `azurerm_managed_hsm_role_*_ids` - use specific resource id to replace generic nested item id ([#25323](https://github.com/hashicorp/terraform-provider-azurerm/issues/25323))
* `azurerm_mssql_database` - add support for `secondary_type` ([#25360](https://github.com/hashicorp/terraform-provider-azurerm/issues/25360))
* `azurerm_monitor_scheduled_query_rules_alert_v2` - support for the `identity` block ([#25365](https://github.com/hashicorp/terraform-provider-azurerm/issues/25365))
* `azurerm_mssql_server_extended_auditing_policy` - support for `audit_actions_and_groups` and `predicate_expression` ([#25425](https://github.com/hashicorp/terraform-provider-azurerm/issues/25425))
* `azurerm_netapp_account` - can now be imported ([#25384](https://github.com/hashicorp/terraform-provider-azurerm/issues/25384))
* `azurerm_netapp_volume` - support for the `kerberos_enabled`, `smb_continuous_availability_enabled`, `kerberos_5_read_only_enabled`, `kerberos_5_read_write_enabled`, `kerberos_5i_read_only_enabled`, `kerberos_5i_read_write_enabled`, `kerberos_5p_read_only_enabled`, and `kerberos_5p_read_write_enabled` properties ([#25385](https://github.com/hashicorp/terraform-provider-azurerm/issues/25385))
* `azurerm_recovery_services_vault` - upgrading to version `2024-01-01` ([#25325](https://github.com/hashicorp/terraform-provider-azurerm/issues/25325))
* `azurerm_stack_hci_cluster` - the `client_id` property is now optional ([#25407](https://github.com/hashicorp/terraform-provider-azurerm/issues/25407))
* `azurerm_storage_encryption_scope` - refactoring to use `hashicorp/go-azure-sdk` rather than `Azure/azure-sdk-for-go` ([#25437](https://github.com/hashicorp/terraform-provider-azurerm/issues/25437))
* `azurerm_mssql_elasticpool` - the `maintenance_configuration_name` property now supports values `SQL_SouthAfricaNorth_DB_1`, `SQL_SouthAfricaNorth_DB_2`, `SQL_WestUS3_DB_1` and `SQL_WestUS3_DB_2` ([#25500](https://github.com/hashicorp/terraform-provider-azurerm/issues/25500))
* `azurerm_lighthouse_assignment` - updating API Version from `2019-06-01` to `2022-10-01` ([#25473](https://github.com/hashicorp/terraform-provider-azurerm/issues/25473))

BUG FIXES:

* `network` - updating the `GatewaySubnet` validation to show the Subnet Name when the validation fails ([#25484](https://github.com/hashicorp/terraform-provider-azurerm/issues/25484))
* `azurerm_function_app_hybrid_connection` - fix an issue during creation when `send_key_name` is specified ([#25379](https://github.com/hashicorp/terraform-provider-azurerm/issues/25379))
* `azurerm_linux_web_app_slot` - fix a crash when upgrading the provider to v3.88.0 or later ([#25406](https://github.com/hashicorp/terraform-provider-azurerm/issues/25406))
* `azurerm_mssql_database` - update the behavior of the `enclave_type` field. ([#25508](https://github.com/hashicorp/terraform-provider-azurerm/issues/25508))
* `azurerm_mssql_elasticpool` - update the behavior of the `enclave_type` field. ([#25508](https://github.com/hashicorp/terraform-provider-azurerm/issues/25508))
* `azurerm_network_manager_deployment` - add locking ([#25368](https://github.com/hashicorp/terraform-provider-azurerm/issues/25368))
* `azurerm_resource_group_template_deployment` - changes to `parameters_content` and `template_content` now force `output_content` to be updated in the plan ([#25403](https://github.com/hashicorp/terraform-provider-azurerm/issues/25403))
* `azurerm_storage_blob` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_container` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_data_lake_gen2_filesystem` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_data_lake_gen2_filesystem_path` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_queue` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share_directory` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share_directory` - resolve an issue where directories might fail to destroy ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share_file` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share_file` - fix several bugs with path handling when creating files in subdirectories ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_web_app_hybrid_connection` - fix an issue during creation when `send_key_name` is specified ([#25379](https://github.com/hashicorp/terraform-provider-azurerm/issues/25379))
* `azurerm_windows_web_app` - prevent a panic during resource upgrade ([#25509](https://github.com/hashicorp/terraform-provider-azurerm/issues/25509))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/88/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-04-26T02:06:49Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

neil-yechenwei added 5 commits December 1, 2023 10:07

New Resource: azurerm_system_center_virtual_machine_manager_server_in…

d0b405b

…ventory_item

update code

cbc8bfa

update code

2add1c6

New Data Source: azurerm_system_center_virtual_machine_manager_invent…

75bcd9a

…ory_items

update code

5a6b186

github-actions bot added documentation service/systemcentervirtualmachinemanager size/L labels Mar 1, 2024

neil-yechenwei marked this pull request as draft March 1, 2024 07:04

update code

0abc941

ms-zhenhua suggested changes Mar 7, 2024

View reviewed changes

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go Outdated Show resolved Hide resolved

...ervirtualmachinemanager/system_center_virtual_machine_manager_inventory_items_data_source.go Outdated Show resolved Hide resolved

github-actions bot added the waiting-response label Mar 7, 2024

update code

d1a2d1c

github-actions bot removed the waiting-response label Mar 7, 2024

neil-yechenwei requested a review from ms-zhenhua March 7, 2024 08:00

ms-zhenhua approved these changes Mar 7, 2024

View reviewed changes

neil-yechenwei marked this pull request as ready for review March 7, 2024 08:48

stephybun requested changes Mar 7, 2024

View reviewed changes

github-actions bot added the waiting-response label Mar 7, 2024

update code

4c75c3b

github-actions bot removed the waiting-response label Mar 8, 2024

neil-yechenwei requested a review from stephybun March 8, 2024 02:51

katbyte requested changes Mar 12, 2024

View reviewed changes

github-actions bot added the waiting-response label Mar 12, 2024

update code

b60cbdd

github-actions bot removed the waiting-response label Mar 12, 2024

neil-yechenwei requested a review from katbyte March 12, 2024 03:33

tombuildsstuff suggested changes Mar 12, 2024

View reviewed changes

github-actions bot added the waiting-response label Mar 12, 2024

update code

384ec69

github-actions bot removed the waiting-response label Mar 13, 2024

neil-yechenwei added 2 commits March 13, 2024 10:41

update code

abb5038

update code

71a1334

neil-yechenwei requested a review from tombuildsstuff March 13, 2024 03:35

katbyte approved these changes Mar 26, 2024

View reviewed changes

katbyte merged commit a7f43da into hashicorp:main Mar 26, 2024
33 checks passed

katbyte added a commit that referenced this pull request Mar 26, 2024

Update CHANGELOG.md #25110

0fd1fb8

github-actions bot added this to the v3.98.0 milestone Mar 26, 2024

github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Data Source: `azurerm_system_center_virtual_machine_manager_inventory_items` #25110

New Data Source: `azurerm_system_center_virtual_machine_manager_inventory_items` #25110

neil-yechenwei commented Mar 1, 2024 •

edited

Loading

ms-zhenhua left a comment

ms-zhenhua left a comment

stephybun left a comment

stephybun Mar 7, 2024

neil-yechenwei Mar 8, 2024

tombuildsstuff Mar 12, 2024

neil-yechenwei Mar 13, 2024

stephybun Mar 7, 2024

neil-yechenwei Mar 8, 2024 •

edited

Loading

tombuildsstuff Mar 12, 2024

neil-yechenwei Mar 13, 2024

stephybun Mar 7, 2024

neil-yechenwei Mar 8, 2024

stephybun Mar 7, 2024

neil-yechenwei Mar 8, 2024

stephybun Mar 7, 2024

neil-yechenwei Mar 8, 2024

neil-yechenwei commented Mar 8, 2024

katbyte left a comment

neil-yechenwei commented Mar 12, 2024

tombuildsstuff left a comment

tombuildsstuff Mar 12, 2024

neil-yechenwei Mar 13, 2024 •

edited

Loading

tombuildsstuff Mar 12, 2024

tombuildsstuff Mar 12, 2024

tombuildsstuff Mar 12, 2024

neil-yechenwei Mar 13, 2024 •

edited

Loading

neil-yechenwei commented Mar 13, 2024 •

edited

Loading

katbyte left a comment

github-actions bot commented Apr 26, 2024

	return fmt.Errorf("no inventory items were found for the System Center Virtual Machine Manager Server %q", scvmmServerId)
	return fmt.Errorf("no inventory items were found for %s", scvmmServerId)


		* `id` - The ID of the System Center Virtual Machine Manager Inventory Items.

		* `inventory_items` - One or more `inventory_item` blocks as defined below.

	A `inventory_item` block exports the following:
	A `inventory_items` block exports the following:

New Data Source: azurerm_system_center_virtual_machine_manager_inventory_items #25110

New Data Source: azurerm_system_center_virtual_machine_manager_inventory_items #25110

Conversation

neil-yechenwei commented Mar 1, 2024 • edited Loading

ms-zhenhua left a comment

Choose a reason for hiding this comment

ms-zhenhua left a comment

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neil-yechenwei Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neil-yechenwei commented Mar 8, 2024

katbyte left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Mar 12, 2024

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neil-yechenwei Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neil-yechenwei Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

neil-yechenwei commented Mar 13, 2024 • edited Loading

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 26, 2024

New Data Source: `azurerm_system_center_virtual_machine_manager_inventory_items` #25110

New Data Source: `azurerm_system_center_virtual_machine_manager_inventory_items` #25110

neil-yechenwei commented Mar 1, 2024 •

edited

Loading

neil-yechenwei Mar 8, 2024 •

edited

Loading

neil-yechenwei Mar 13, 2024 •

edited

Loading

neil-yechenwei Mar 13, 2024 •

edited

Loading

neil-yechenwei commented Mar 13, 2024 •

edited

Loading