Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_security_rule: fixed app id read & import #2558

Merged
merged 1 commit into from
Dec 21, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions azurerm/resource_arm_network_security_rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,14 @@ func resourceArmNetworkSecurityRuleRead(d *schema.ResourceData, meta interface{}
d.Set("access", string(props.Access))
d.Set("priority", int(*props.Priority))
d.Set("direction", string(props.Direction))

if err := d.Set("source_application_security_group_ids", flattenApplicationSecurityGroupIds(props.SourceApplicationSecurityGroups)); err != nil {
return fmt.Errorf("Error setting `source_application_security_group_ids`: %+v", err)
}

if err := d.Set("destination_application_security_group_ids", flattenApplicationSecurityGroupIds(props.DestinationApplicationSecurityGroups)); err != nil {
return fmt.Errorf("Error setting `source_application_security_group_ids`: %+v", err)
}
}

return nil
Expand Down Expand Up @@ -345,3 +353,15 @@ func resourceArmNetworkSecurityRuleDelete(d *schema.ResourceData, meta interface

return nil
}

func flattenApplicationSecurityGroupIds(groups *[]network.ApplicationSecurityGroup) []string {
ids := make([]string, 0)

if groups != nil {
for _, v := range *groups {
ids = append(ids, *v.ID)
}
}

return ids
}