Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vertexai): add vertex_ai_index_endpoint for Vertex AI Matching Engine #5738

Merged
merged 1 commit into from
Jun 7, 2023
Merged

feat(vertexai): add vertex_ai_index_endpoint for Vertex AI Matching Engine #5738

merged 1 commit into from
Jun 7, 2023

Conversation

modular-magician
Copy link
Collaborator

Part of hashicorp/terraform-provider-google#12818
Part of hashicorp/terraform-provider-google#9298

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertex_ai_index_endpoint

Derived from GoogleCloudPlatform/magic-modules#6873

@modular-magician
feat(vertexai): add vertex_ai_index_endpoint for Vertex AI Matching E…
94ce0cd 
…ngine (hashicorp#6873)

* feat: create vertex_ai_index_endpoint

* fix: remove a white line

* feat: add a comment about deployedIndexes [ci skip]

* feat: add an unit test to check update

* fix: fix the handwritten test name to avoid a conflict

* fix: fix unnecessary code from test

* fix: use immutable instead of input

* refactor: refactor test code with acctest and tpgresource

* test: update network_name to use the unique names

* test: fix an invalid label definition

* feat: increase timeout from 20m to 1h regarding vertex ai index endpoint

* test: increase the timeouts to 120m

* Apply suggestions from code review

* feat: update test and yaml to clarify the fields mutabilities

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 9ea4f75 into hashicorp:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician