Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_cloudbuild_trigger doesn't support user-specified service accounts #10088

Closed
eriksw opened this issue Sep 16, 2021 · 3 comments
Closed

Comments

@eriksw
Copy link

eriksw commented Sep 16, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Google Cloud Build now supports specifying a service account (other than the default one) for builds and triggers to run as.

Until google_cloudbuild_trigger supports this, it is impossible to use terraform to manage build triggers that make use of this critical security feature. (Without this feature, there is no way to let only some builds execute with sensitive access such as the ability to modify production, without also granting that access to other builds that should not have that access.)

New or Affected Resource(s)

  • google_cloudbuild_trigger

Potential Terraform Configuration

resource "google_cloudbuild_trigger" "build-trigger" {
  ...

  build {
    ...
    options {
      service_account_email = "myserviceaccount@myproject.iam.gserviceaccount.com"
    }
  }  
}

References

@eriksw
Copy link
Author

eriksw commented Sep 16, 2021

Note that it is possible (and quite importantly so) to specify the service account for a trigger where the build definition is in the sources instead of the trigger config, so having the setting under build -> options is probably not the right place for it.

@eriksw
Copy link
Author

eriksw commented Sep 16, 2021

Duplicate of #10053

@eriksw eriksw closed this as completed Sep 16, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant