Skip to content
This repository has been archived by the owner on Nov 14, 2020. It is now read-only.

Rabbitmq Shovel definition is incomplete and invalid because the source and destination protocols are unspecified #61

Closed
AgrimPrasad opened this issue Sep 21, 2020 · 2 comments · Fixed by #60

Comments

@AgrimPrasad
Copy link

AgrimPrasad commented Sep 21, 2020

Terraform Version

0.13.3

Affected Resource(s)

  • rabbitmq_shovel

Terraform Configuration Files

resource "rabbitmq_shovel" "shovelTest" {
    name = "shovelTest"
    vhost = "${rabbitmq_vhost.test.name}"
    info {
        source_uri = "amqp:///test"
        source_exchange = "${rabbitmq_exchange.test.name}"
        source_exchange_key = "test"
        destination_uri = "amqp:///test"
        destination_exchange = "${rabbitmq_exchange.test.name}"
    }
}

Expected Behavior

Valid Rabbitmq Shovel should have been created.

Actual Behavior

Invalid Rabbitmq Shovel created due to empty Rabbitmq source/destination protocols (see attached screenshot of the Rabbitmq Management UI with empty source and destination protocol fields).

Screenshot 2020-09-21 at 11 49 32 AM

Steps to Reproduce

terraform apply although I'm using the pulumi rabbitmq provider which wraps terraform: https://github.com/pulumi/pulumi-rabbitmq

Important Factoids

We should update to use all the underlying rabbitmq shovel fields as the underlying rabbitmq go library has been updated (see reference PR below)

References

Underlying rabbitmq library has been updated with all required fields. Add missing Parameters for Shovels michaelklishin/rabbit-hole#157

@AgrimPrasad
Copy link
Author

Ah I see there's already a PR #60 which should close this.

@alex-voigt
Copy link

Could someone please take a look at the PR? I also need that feature :-)

@cyrilgdn cyrilgdn linked a pull request Oct 9, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants