Add tagging support for AWS ASG (cont. 1080) #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: update CHANGELOG providers/digitalocean: add dot in GET response providers/digitalocean: force fqdn in dns rr value update CHANGELOG Add disk size to google_compute_instance disk blocks. 'project' should be set to the project's ID, not its name. Don't error when enabling DNS hostnames in a VPC Correct AWS VPC or route table read functions Updates to GCE Instances and Instance Templates to allow for false values to be set for the auto_delete setting. Update GCE Instance Template tests now that existing disk must exist prior to template creation. Update Google API import to point to the new location. add network field to the network_interface
catsby
changed the title
|
Nice! LGTM |
catsby
added a commit
that referenced
this pull request
Mar 26, 2015
Add tagging support for AWS ASG (cont. 1080)
|
|
mikkoc
pushed a commit
to alphagov/paas-alpha-tsuru-terraform
that referenced
this pull request
Apr 10, 2015
At the moment instances created via Autoscaling Group do not get tagged. See: hashicorp/terraform#1319 This is not implemented in Terraform 0.3.7 but as soon as we switch to 0.4.0 this will be available.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues and supersedes #1080 , with some minor code cleanups to get acceptance tests passing