Add provider sensitivity propagation experiment #26706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
pselle
force-pushed
the
pselle/provider-sens-experiment
branch
from
403118b
to
21d117b
Compare
alisdair
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
This is a neat way to ensure there are no breaking changes! 🎉
I left a suggestion about expanding the upgrade guide a bit, but it's not a must-have. We might want to update the reporter of #26625 to let them know that the behaviour they were looking for will be marked experimental for 0.14.
pselle
force-pushed
the
pselle/provider-sens-experiment
branch
2 times, most recently
from
fc1577e
to
81c0bb6
Compare
Rolls back marking attributes providers mark as sensitive to an `experiment` and adds associated docs and adjustments to the upgrade guide.
pselle
force-pushed
the
pselle/provider-sens-experiment
branch
from
81c0bb6
to
bd70bc6
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back marking attributes providers mark as sensitive to an
experimentand adds associated docs and adjustmentsto the upgrade guide. This is making #26590 experimental, rather than default, and I submitting this for a 0.14 backport.
To propagate sensitivity to attributes providers mark as sensitive, activate the experiment in the
terraformblock: