Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/azurerm: updating the dependencies for the Azure Backend #26721

Merged
merged 4 commits into from
Feb 17, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates the following dependencies:

  • github.com/Azure/azure-sdk-for-go to v47.1.0
  • github.com/Azure/go-autorest to v0.11.10
  • github.com/hashicorp/go-azure-helpers to v0.13.0
  • github.com/tombuildsstuff/giovanni to v0.14.0

Which ultimately fixes a crash identified as a part of debugging #26645

Tests pass:

$ TF_ACC=1 go test -v ./backend/remote-state/azure/... -timeout=90m
=== RUN   TestBackend_impl
--- PASS: TestBackend_impl (0.00s)
=== RUN   TestBackendConfig
--- PASS: TestBackendConfig (0.00s)
=== RUN   TestBackendAccessKeyBasic
--- PASS: TestBackendAccessKeyBasic (133.51s)
=== RUN   TestBackendManagedServiceIdentityBasic
    helpers_test.go:38: Skipping test since not running in Azure
--- SKIP: TestBackendManagedServiceIdentityBasic (0.00s)
=== RUN   TestBackendSASTokenBasic
--- PASS: TestBackendSASTokenBasic (133.03s)
=== RUN   TestBackendServicePrincipalClientCertificateBasic
    backend_test.go:132: Skipping since `ARM_CLIENT_CERTIFICATE_PATH` is not specified!
--- SKIP: TestBackendServicePrincipalClientCertificateBasic (0.00s)
=== RUN   TestBackendServicePrincipalClientSecretBasic
--- PASS: TestBackendServicePrincipalClientSecretBasic (139.30s)
=== RUN   TestBackendServicePrincipalClientSecretCustomEndpoint
    backend_test.go:198: Skipping as ARM_ENDPOINT isn't configured
--- SKIP: TestBackendServicePrincipalClientSecretCustomEndpoint (0.00s)
=== RUN   TestBackendAccessKeyLocked
--- PASS: TestBackendAccessKeyLocked (132.04s)
=== RUN   TestBackendServicePrincipalLocked
--- PASS: TestBackendServicePrincipalLocked (131.49s)
=== RUN   TestRemoteClient_impl
--- PASS: TestRemoteClient_impl (0.00s)
=== RUN   TestRemoteClientAccessKeyBasic
--- PASS: TestRemoteClientAccessKeyBasic (136.58s)
=== RUN   TestRemoteClientManagedServiceIdentityBasic
    helpers_test.go:38: Skipping test since not running in Azure
--- SKIP: TestRemoteClientManagedServiceIdentityBasic (0.00s)
=== RUN   TestRemoteClientSasTokenBasic
--- PASS: TestRemoteClientSasTokenBasic (130.42s)
=== RUN   TestRemoteClientServicePrincipalBasic
--- PASS: TestRemoteClientServicePrincipalBasic (132.30s)
=== RUN   TestRemoteClientAccessKeyLocks
--- PASS: TestRemoteClientAccessKeyLocks (185.56s)
=== RUN   TestRemoteClientServicePrincipalLocks
--- PASS: TestRemoteClientServicePrincipalLocks (133.59s)
=== RUN   TestPutMaintainsMetaData
--- PASS: TestPutMaintainsMetaData (130.89s)
PASS
ok  	github.com/hashicorp/terraform/backend/remote-state/azure	1518.741s

* github.com/Azure/azure-sdk-for-go to v47.1.0
* github.com/Azure/go-autorest to v0.11.10
* github.com/hashicorp/go-azure-helpers to v0.13.0
* github.com/tombuildsstuff/giovanni to v0.14.0
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Oct 29, 2020
@alisdair
Copy link
Member

@tombuildsstuff Could you try rebasing this PR against latest master before merging? The backport-assistant configuration needs to be updated to auto-open the backport PR.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #26721 (cb04105) into master (a351053) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
backend/remote-state/azure/arm_client.go 6.60% <0.00%> (ø)
internal/providercache/dir.go 67.34% <0.00%> (-6.13%) ⬇️
states/statefile/version4.go 58.19% <0.00%> (+0.23%) ⬆️
dag/marshal.go 63.49% <0.00%> (+1.58%) ⬆️

@ghost
Copy link

ghost commented Mar 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/azure dependencies Auto-pinning enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants