Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-getter to v1.5.0 #26762

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Upgrade go-getter to v1.5.0 #26762

merged 1 commit into from
Nov 4, 2020

Conversation

alisdair
Copy link
Member

Upstream changelog:

v1.5.0

v1.4.2

  • Expose a Umask option to mask file permissions when storing local files or decompressing an archive. Helpful for clearing setuid or other sensitive bits.
  • feat(detector): provide a detector for repositories hosted on GitLab.com
  • Use default AWS credential chain under normal circumstances

Also run go mod tidy.

Fixes #20439 (via the AWS credential chain change in 1.4.2)

@alisdair alisdair added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Oct 30, 2020
@alisdair alisdair requested a review from a team October 30, 2020 19:38
@alisdair alisdair self-assigned this Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #26762 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
internal/providercache/package_install.go 22.93% <100.00%> (ø)
terraform/evaluate.go 53.11% <0.00%> (+0.41%) ⬆️
backend/remote/backend_common.go 52.32% <0.00%> (+0.71%) ⬆️
terraform/node_resource_apply_instance.go 75.78% <0.00%> (+0.78%) ⬆️
terraform/eval_diff.go 67.43% <0.00%> (+0.91%) ⬆️
dag/marshal.go 54.79% <0.00%> (+1.36%) ⬆️

Includes fix for breaking upstream API change.
@alisdair alisdair merged commit 4da3e01 into master Nov 4, 2020
@alisdair alisdair deleted the alisdair/upgrade-go-getter branch November 4, 2020 14:12
@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform does not use AWS Task Roles to fetch modules from s3
2 participants