Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks: Refactor existing check addrs and add new check block addr #32733

Merged
merged 4 commits into from Mar 23, 2023

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Feb 22, 2023

This PR adds an address structure for referencing the new Check blocks within Terraform. As part of this, I have refactored the existing Check address structure and Checkable interface.

  • Renamed the old Check address structure to CheckRule to better describe what it is actually referencing, and meaning we can use the name Check to reference actual Check blocks.
  • Moved the new CheckRule address and Checkable interface into their own files.
  • Introduced a new Check address that describes a single Check block.

For now, the actual Check blocks don't exist yet so nothing is referencing the new Check addresses yet.


This PR is part of chain of PRs introducing the new Checks feature into Terraform for v1.5. The chain of PRs is as follows:

Branch Description Pull Request
liamcervante/checks/scoped Add support for scoped resources. #32732
liamcervante/checks/addr Add Terraform addresses for new Check blocks. #32733
liamcervante/checks/configs Add config parsing new Check blocks. #32734
liamcervante/checks/graph Add nodes and transforms for processing new Check blocks. #32735

I have created the chain to make reviewing the smaller contained part of the process easier. IF you want to view all the changes together in a single PR, navigate to the last PR in the chain and compare it to the main branch and you will see all changes from all prior PRs in a single place.

@liamcervante liamcervante requested review from apparentlymart and a team March 8, 2023 10:46
@liamcervante liamcervante marked this pull request as ready for review March 8, 2023 10:49
Base automatically changed from liamcervante/checks/scoped to main March 10, 2023 10:11
Copy link
Member

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I was concerned that this change modified the enum types, and didn't update the state file decoding/encoding. But I see that's handled as part of #32735 so that's fine.

internal/addrs/check.go Show resolved Hide resolved
@liamcervante liamcervante merged commit 87c4577 into main Mar 23, 2023
4 checks passed
@liamcervante liamcervante deleted the liamcervante/checks/addr branch March 23, 2023 08:04
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants