New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks: Refactor existing check addrs and add new check block addr #32733
Conversation
2760764
to
0a24388
Compare
0a24388
to
020b2ed
Compare
020b2ed
to
0ecb54c
Compare
d0a15b7
to
de03bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I was concerned that this change modified the enum types, and didn't update the state file decoding/encoding. But I see that's handled as part of #32735 so that's fine.
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds an address structure for referencing the new
Check
blocks within Terraform. As part of this, I have refactored the existingCheck
address structure andCheckable
interface.Check
address structure toCheckRule
to better describe what it is actually referencing, and meaning we can use the nameCheck
to reference actualCheck
blocks.CheckRule
address andCheckable
interface into their own files.Check
address that describes a singleCheck
block.For now, the actual
Check
blocks don't exist yet so nothing is referencing the newCheck
addresses yet.This PR is part of chain of PRs introducing the new Checks feature into Terraform for v1.5. The chain of PRs is as follows:
liamcervante/checks/scopedI have created the chain to make reviewing the smaller contained part of the process easier. IF you want to view all the changes together in a single PR, navigate to the last PR in the chain and compare it to the main branch and you will see all changes from all prior PRs in a single place.