Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks: Add configuration for check blocks #32734

Merged
merged 7 commits into from Mar 23, 2023

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Feb 22, 2023

This PR adds the concrete configuration for the new Check blocks.

  • It creates a new Check structure, which contains a single DataResource and slice of CheckRules.
  • It uses the scoped functionality from Checks: Add support for scoped resources. #32732 to ensure other resources cannot access the embedded DataResource.
  • It updates DataResource so meta and lifecycle attributes are not accessible to nested DataResource objects.

This PR is part of chain of PRs introducing the new Checks feature into Terraform for v1.5. The chain of PRs is as follows:

Branch Description Pull Request
liamcervante/checks/scoped Add support for scoped resources. #32732
liamcervante/checks/addr Add Terraform addresses for new Check blocks. #32733
liamcervante/checks/configs Add config parsing new Check blocks. #32734
liamcervante/checks/graph Add nodes and transforms for processing new Check blocks. #32735

I have created the chain to make reviewing the smaller contained part of the process easier. IF you want to view all the changes together in a single PR, navigate to the last PR in the chain and compare it to the main branch and you will see all changes from all prior PRs in a single place.

Base automatically changed from liamcervante/checks/addr to main March 23, 2023 08:04
@liamcervante liamcervante merged commit 3827120 into main Mar 23, 2023
4 checks passed
@liamcervante liamcervante deleted the liamcervante/checks/configs branch March 23, 2023 08:12
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants