stacks: call terraform.Validate on stack component configs #34705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisdair
approved these changes
Feb 20, 2024
Base automatically changed from
liamcervante/external-provider-validate
to
main
February 21, 2024 09:47
liamcervante
force-pushed
the
liamcervante/stacks/validate-components
branch
from
ff6851d
to
be21796
Compare
liamcervante
force-pushed
the
liamcervante/stacks/validate-components
branch
from
be21796
to
68ab945
Compare
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the stacks validate functionality so that it calls out to
terraform.Validatefor each component within the stack.We've updated the
terraform1API such that the deps file and provider cache handles are now required for theValidateStackConfigurationRPC. Follow up PRs will update the various clients with this new behaviour. This is a forward-compatible change, so we can update the clients now before the new Terraform version is released and they'll continue working with the old version of Terraform. Unfortunately, this isn't backwards compatible so any clients not updated will start erroring when calling Terraform without the new validate fields.We load the unconfigured providers in
component_config.go, and pass them into the external providers supported byterraform.Validate(see #34701).There are extra static validations we can do within stacks only that will arrive in follow up PRs.