stacks: check providers blocks in components during validatation #34707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisdair
approved these changes
Feb 20, 2024
liamcervante
force-pushed
the
liamcervante/stacks/validate-components
branch
2 times, most recently
from
be21796
to
68ab945
Compare
Base automatically changed from
liamcervante/stacks/validate-components
to
main
February 21, 2024 09:58
liamcervante
force-pushed
the
liamcervante/stacks/validate-providers
branch
from
9360d69
to
92f926b
Compare
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly checks the diagnostics produced by the
CheckProviderfunction added in the last PR (#34705) as part of the stacks validate functionality. This means we get error messages if there are missing or undeclared providers in theprovidersblock for components.I've also added two additional test cases that are currently skipped during tests that describe assigning providers with the same underlying types but different local names (or the reverse in the error case). This isn't currently support but probably should be. I've expanded a TODO calling this out. I'll revisit this in a future PR.