deferred actions: fix config generation when importing an unknown resource #35319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
approved these changes
Jun 12, 2024
Base automatically changed from
liamcervante/deferred-actions/unknown-import-id
to
main
June 12, 2024 10:59
… unknown resource
liamcervante
force-pushed
the
liamcervante/deferred-actions/unknown-import-config-gen
branch
from
31485ff
to
fef3696
Compare
liamcervante
deleted the
liamcervante/deferred-actions/unknown-import-config-gen
branch
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes config generation when importing a resource with an unknown ID.
Previously, we would return an error and then crash when generating config for a resource with an unknown import ID. This PR updates the planning process so it exits early with a dummy value instead of attempting to validate configuration that doesn't exist.
The config will be properly generated in a follow up plan when the import ID is known.