stacks: applyable status should be dependent on applyable components #35350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
approved these changes
Jun 17, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic for deciding whether an overall stack is "applyable" so that it takes into account the applyable status of all component instances.
Previously, a stack was "applyable" as long as it had no error diagnostics. Now, a stack is applyable if it (a) has no error diagnostics and (b) at least one component is "applyable".
Finally, stack outputs are not currently stored as part of the state of a stack anywhere. This means that there is no need for the applyable status of a stack to depend on outputs. I've updated a TODO within the code that is calling for outputs to be added to state so that it also calls out that if/when this happens the applyable status of a stack should be updated to reflect that status of any outputs.