Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/triton: New provider for Joyent Triton #5738

Merged
merged 1 commit into from
Mar 20, 2016

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Mar 20, 2016

This brings across the following resources for Triton from the joyent/triton-terraform repository, and converts them to the canonical Terraform style, introducing Terraform-style documentation and acceptance tests which run against the live API rather than the local APIs:

  • triton_firewall_rule
  • triton_machine
  • triton_key

This was previously merged as #5277, but was reverted in 85b4b58 because of some incompatible licensing which became apparent post-merge. These have now been resolved by @misterbisson and the team at Joyent, so this can be re-merged!

This brings across the following resources for Triton from the
joyent/triton-terraform repository, and converts them to the canonical
Terraform style, introducing Terraform-style documentation and
acceptance tests which run against the live API rather than the local
APIs:

- triton_firewall_rule
- triton_machine
- triton_key
@phinze
Copy link
Contributor

phinze commented Mar 20, 2016

LGTM - let's do this thing!

@jen20
Copy link
Contributor Author

jen20 commented Mar 20, 2016

Acceptance test run:

$ make testacc TEST=./builtin/providers/triton
==> Checking that code complies with gofmt requirements...
/Users/James/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/triton -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccTritonFirewallRule_basic
--- PASS: TestAccTritonFirewallRule_basic (8.17s)
=== RUN   TestAccTritonFirewallRule_update
--- PASS: TestAccTritonFirewallRule_update (13.69s)
=== RUN   TestAccTritonFirewallRule_enable
--- PASS: TestAccTritonFirewallRule_enable (13.01s)
=== RUN   TestAccTritonKey_basic
--- PASS: TestAccTritonKey_basic (17.82s)
=== RUN   TestAccTritonMachine_basic
--- PASS: TestAccTritonMachine_basic (167.51s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/triton 220.206s

jen20 added a commit that referenced this pull request Mar 20, 2016
provider/triton: New provider for Joyent Triton
@jen20 jen20 merged commit 1f8dede into master Mar 20, 2016
@jen20 jen20 deleted the f-joyent-triton-licenses branch March 20, 2016 20:42
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants