Update crypto/ssh to support ED25519 SSH keys

[passcod]

ED25519 key support was added in golang/crypto@1e61df8. This is
needed to parse and support "new format" SSH keys prefixed with:

-----BEGIN OPENSSH PRIVATE KEY-----

Fixes #5156

[jen20]

Hi @passcod! Thanks for opening a pull request. I agree this does need to be done - however I think there is an issue with the way govendor has been used to generate the diff - we have multiple commit SHAs for the same git repository. Could you take a look at rectifying this prior to merging? Thanks!

[passcod]

Ah, originally I'd done a

govendor fetch golang.org/x/crypto

but that vendored the entire crypto repo, which, looking at the existing vendor.json, I thought you were trying to avoid (you're only pulling the SSH subpath). So instead I ran

govendor fetch golang.org/x/crypto/ssh

which updated the ssh subpath and then pulled in the ed25519 subpaths along because they're dependencies I guess.

Should I remove crypto/ssh and fetch in the entire crypto library?

[stack72]

Hi @passcod

Thanks for the work here - I have just updated the dependency in #9661

Thanks

Paul

[passcod]

Thanks

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.