-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppet environment variables #7931
Conversation
@@ -52,6 +52,9 @@ available below this section. | |||
* `environment_path` (string) - Path to the directory that contains environment | |||
files on the host disk. | |||
|
|||
* `environment_variables` (hash) - A hash of data to be set as environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we provide an example here? or document that it's string -> string?
@@ -85,6 +87,9 @@ def finalize! | |||
if @manifest_file == UNSET_VALUE | |||
@manifest_file = nil | |||
end | |||
if @environment_variables == UNSET_VALUE | |||
@environment_variables = nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, if you set this to {}
, you'll have a better day. Then you don't need any nil checks - you can just .each it all the way 🏡
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Completes #7252 which did not include actual usage of configuration defined environment variables.
Fixes: #2270