Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read config endpoint does not indicate if token_reviewer_jwt is set #68

Open
coryflucas opened this issue Jul 24, 2019 · 2 comments · Fixed by #221
Open

Read config endpoint does not indicate if token_reviewer_jwt is set #68

coryflucas opened this issue Jul 24, 2019 · 2 comments · Fixed by #221

Comments

@coryflucas
Copy link

Currently since the read config endpoint does not expose the token_reviewer_jwt field for security reasons, but there is no indication if it is set or not. Because this field is optional, it doesn't seem to be possible to tell if its set other than trying to login with a kubernetes JWT that does not have access to the token reviewer API. It would be nice if the API returned the token_reviewer_jwt masked, or just a field that indicate it was set (something like token_reviewer_jwt_provided as a boolean).

Happy to provide a PR if this is something you'd be interested in supporting.

Thanks for the great product!

@pschulten
Copy link

@coryflucas if you set up the config with terraform you can check if token_reviewer_jwt is set in the state file

@komapa
Copy link

komapa commented May 20, 2023

You should really just return the sha256 of the value so you can allow tools like terraform to fix drift. That will solve 99.9% of the use cases to get it from the config api endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants