This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
core/cli: Update profile set to use defaults on init only #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit when updating a runner profile with waypoint runner profile set, the command would reset all unset configs to their defaults. This commit checks first if the flag exists before setting it to the value in the flag, otherwise we prefer the already set configuration.
demophoon
force-pushed
the
f-runner-profile-config-update
branch
from
4f3ce70
to
30fb1e0
Compare
|
Just pulled this branch and have been trying it out locally, it's beautiful ✨ |
izaaklauer
approved these changes
Oct 3, 2022
izaaklauer
reviewed
Oct 3, 2022
| @@ -44,5 +44,6 @@ lifecycle operation. | |||
| - `-default` - Indicates that this remote runner profile should be the default for any project that doesn't otherwise specify its own remote runner. | |||
| - `-target-runner-id=<string>` - ID of the runner to target for this remote runner profile. | |||
| - `-target-runner-label=<key=value>` - Labels on the runner to target for this remote runner profile. e.g. `-target-runner-label=k=v`. Can be specified multiple times. | |||
| - `-target-runner-any` - Set profile to target any available runner. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies
runner profile setto use profile defaults only when setting up an initial profile instead of resetting the profile to defaults when updating an existing profile.Fixes #3853