This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix order of HTTP and gRPC server addresses in Nomad server install #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sequence of addresses returned for the installation of Waypoint to Nomad was incorrect before this commit, when using Consul service discovery. The HTTP server address is now correctly returned firstly, followed by the gRPC server address.
paladin-devops
force-pushed
the
b-nomad-consul-install
branch
from
6266002
to
b7f0cd8
Compare
briancain
approved these changes
Jan 4, 2023
paladin-devops
requested review from
a team
and removed request for
demophoon and
xiaolin-ninja
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4358.