This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
core/api: Add grpc-gateway api #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
reviewed
Jan 19, 2023
demophoon
force-pushed
the
feat/main/public-api
branch
from
2c1879c
to
a4ca145
Compare
We need to use the same dial options when setting up GRPC-Gateway for GRPC-Gateway to properly proxy requests through
This commit enables an HTTP API on the http port of Waypoint. This utilizes grpc-gateway to pass through http request to grpc calls and then routes the grpc responses back to the http client using json as the transport.
This commit removes the basepath from all routes defined within the grpc-gateway.yml file for it to be configurable by an api client. This is also added to the swagger.json file so the by default anyone consuming the swagger spec will have the correct definitions for their implementation of server
demophoon
force-pushed
the
feat/main/public-api
branch
from
d48fd11
to
18d2b32
Compare
evanphx
approved these changes
Feb 8, 2023
briancain
approved these changes
Feb 8, 2023
Co-authored-by: Brian Cain <bcain@hashicorp.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables gRPC-Gateway on the http port of Waypoint server to add in an HTTP API for interfacing with Waypoint.
Most of this PR is autogenerated from the existing
server.swagger.jsonfile that is directly generated from our protos.