This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Update target group destroyer to wait for listener #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the ECS platform destroyer to wait for there to be zero AWS ALB listeners targeting the target group to attempt to delete the target group, for a maximum of 5 minutes.
paladin-devops
force-pushed
the
b-target-group-destroyment
branch
from
cec6b24
to
aa2bcb0
Compare
|
When #4496 is addressed, it might be nicer to update the ECS default releaser to modify the listener to no longer route to the target group; but this will do for now. |
briancain
reviewed
Feb 9, 2023
There should be only one target group returned by the ARN lookup, so this is now enforced by returning an error if that is not the case. This allows for the elimination of the most exterior loop in the deletion of the target group.
briancain
approved these changes
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ECS platform destroyer to wait for there to be zero AWS ALB listeners targeting the target group to attempt to delete the target group, for a maximum of 5 minutes.
This does not fully address #4461, because my destroy attempts are still failing on deleting the security group, but it's a start! And deleting that will be fixed in a subsequent PR.