This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Runner token ID check #4707
Merged
Runner token ID check #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
force-pushed
the
b-runner-id-token
branch
from
1911a84
to
ddbcbd7
Compare
paladin-devops
force-pushed
the
b-runner-id-token
branch
from
ddbcbd7
to
5429a09
Compare
ID of the runner token and the ID of the newly requested runner token must match.
paladin-devops
force-pushed
the
b-runner-id-token
branch
from
5429a09
to
0fa1be0
Compare
pkg/server/singleprocess/auth.go
Outdated
| case *pb.Token_Runner_: | ||
| // Prevent a runner token from generating a token for a runner with an | ||
| // ID different from the ID encoded in the runner token | ||
| if k.Runner.Id != req.Id { |
There was a problem hiding this comment.
Looks great to me! We should also check to make sure that k.Runner.Id would never be nil, and also add a test for this new check.
evanphx
approved these changes
May 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in this PR prevents a runner token from being used to generate a new token for a runner other than the runner ID which is encoded in the runner token.