-
Notifications
You must be signed in to change notification settings - Fork 327
Make ecs platform alb.load_balancer_arn optional #4729
Conversation
Hey @supaspoida , thank you for the PR! 😄 Could you also add a changelog to this PR? You can add a release note in a file named |
ae30562
to
128ef4f
Compare
128ef4f
to
345ff61
Compare
@paladin-devops took a crack at the changelog, tried to follow patterns from existing entries, let me know if anything is off! |
Hey @supaspoida sorry for the delay here; it looks like we need 1 more thing here and that's to run |
345ff61
to
509b241
Compare
@catsby I had a feeling there was probably a docs update needed, thanks for the pointer! I've run I've left it as a separate WIP commit instead of squashing because I hit issues at the content formatting step here: https://github.com/hashicorp/waypoint/blob/main/Makefile#L209 I got a 404 for the All that to say, this is my best attempt at pulling out only the expected docs changes without all of the unrelated formatting updates. If you'd like me to include everything I can do that instead, or if there is something I missing around the mdx formatting let me know! |
509b241
to
7bcd018
Compare
Hey @supaspoida, thanks again for this PR! We are going to merge this PR in as-is, and open up a quick follow-up for the docs fix. Thank you for your contribution!! |
Updates the ecs platform plugin to make
alb.load_balancer_arn
optional as per comment here: #4680 (comment)Fixes: #4680