Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createBrowserHistory #62

Closed
sylvainlap opened this issue Feb 23, 2016 · 4 comments
Closed

createBrowserHistory #62

sylvainlap opened this issue Feb 23, 2016 · 4 comments

Comments

@sylvainlap
Copy link
Contributor

In client/index.js, there is a

import createBrowserHistory from 'history/lib/createBrowserHistory';

However, this is never used.

What is the purpose of this import ?

@SOSANA
Copy link
Contributor

SOSANA commented Feb 23, 2016

@sandeeppanda92 feed back? can we close this issue?

@carloscuatin
Copy link
Contributor

the target is to use createBrowserHistory If you are using the what is done in no time is imported browserHistory from react-router ??

@SOSANA
Copy link
Contributor

SOSANA commented Feb 24, 2016

@carloscuatin @sylvainlap ya this is interesting I got mixed up with import { Router, browserHistory, Route, IndexRoute, match } from 'react-router'; :(

@sandeeppanda92 curious now as well?

@panda-sandeep
Copy link
Member

@sylvainlap @SOSANA @carloscuatin Removed createBrowserHistory as we are no longer using it. Thanks for noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants