Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should all retries load from :retries configuration value? #249

Open
ibarrae opened this issue Jun 15, 2020 · 1 comment
Open

Should all retries load from :retries configuration value? #249

ibarrae opened this issue Jun 15, 2020 · 1 comment

Comments

@ibarrae
Copy link

ibarrae commented Jun 15, 2020

Hi folks, first let me thank and congratulate you for this library, it has been great and really helpful 🎉.

My following doubt is the following:

Shouldn't all default "retries" arguments load from this retries function?

I have seen that functions like search_element and find_all_elements that have a default of "5". Making it hard to use the "configurable" value. Maybe I'm doing something wrong or what could be done to use "configurable" value by default on these functions?

Thanks in advance for the help!

@danhper
Copy link
Collaborator

danhper commented Aug 9, 2020

Hi!
This would indeed be a much better behaviour. I do not have much time right now but if you want to send a PR to fix this it would be very welcome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants