Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hr vimbundles, command not found. Readme or command needs update. #60

Closed
MichaelDimmitt opened this issue Aug 13, 2017 · 6 comments
Closed

Comments

@MichaelDimmitt
Copy link

MichaelDimmitt commented Aug 13, 2017

Hello, on a factory restored MacBook computer ,
note: mac using default bash terminal

The problem,

The readme for dotmatrix states run:
cd dotmatrix;
bin/install;
Then
hr vimbundles;

The result, hr command not found.

The fix, (workaround for the problem)

When in dot-matrix directory,
Run the hr bin script:
./hr/bin/hr;

Now it seemed the hr command will be found in future use.

Summary, perhaps bin/install; is not performing the install for hr command.

Possible resolution,

Inside of #bin/install

Possible problem: $PWD/hr/bin/hr autoinstall

Possible resolution: ./$PWD/hr/bin/hr autoinstall
to actually run the script for autoinstall.


Not a duplicate of #47
@plicjo
Copy link
Contributor

plicjo commented Aug 24, 2017

Did you restart your shell after running bin/install?

@MichaelDimmitt
Copy link
Author

@plicjo, apologies taking so long to respond.
Yep, I had tried restarting the shell.
I think the solution needs to be coded and that the script is not being run.

I can make a pull request if there is interest.
To show how small the change would be.
The big question, "will it actually make a difference?"
That question will not be answered until the issue is able to be replicated by others.

The trouble, to replicate the issue you almost have to factory restore your computer.
Thereby making yourself a user with no preinstalled programmer tools.

@dkarter
Copy link
Contributor

dkarter commented Sep 4, 2017

@MichaelDimmitt thanks for opening this issue!

I noticed in your issue description that you spelled the command hr vimbundles which is not correct. The correct command is hr vimbundle (singular as opposed to plural). This may have been the cause for the command not found message you were seeing. 🙂

The solution we use to install Vim plugins has recently changed to Vim Plug (see #64). The issue you were experiencing was prior to that change. I recommend you get the latest dotmatrix and follow the instructions here https://github.com/hashrocket/dotmatrix/blob/master/README.md#vim-plugins to see if this issue is still replicatable.

The short of it is that you no longer need to use hr vimbundle instead you will be able to install plugins using :PlugInstall directly from Vim and :PlugUpdate to update your plugins.

I recently installed the latest dotmatrix (w/ Vim Plug) on a fresh Ubuntu machine and did not encounter any issues at all. If you are still able to replicate the problem on a fresh Virtual Box machine please let us know, otherwise feel free to close this issue.

@MichaelDimmitt
Copy link
Author

@dkarter, great idea.
I believe the code was a fresh clone of dotmatrix because I was on a new programmer's computer.
I will check on the typo.
However, I remember after running the install script 'hr vimbundle' was working.

@dkarter
Copy link
Contributor

dkarter commented Sep 22, 2017

Closing this issue for now. If you find a way to replicate the issue please let me know I'll reopen.

@dkarter dkarter closed this as completed Sep 22, 2017
@MichaelDimmitt
Copy link
Author

MichaelDimmitt commented Sep 23, 2017

@dkarter, thats fair.
If I get my computer in the correct environment to replicate it many times,
then I will be back. 🙂 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants