Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code format using new elixir code formatter #212

Closed
wants to merge 1 commit into from
Closed

Code format using new elixir code formatter #212

wants to merge 1 commit into from

Conversation

kartikjagdale
Copy link

  1. Format lib folder and test folder
  2. Added formatter so you can format entire app without specifying the file names
    see Format auth_controller.ex #189

2. Add formatter so you can format entire app without specifying the file names
@jwworth
Copy link
Contributor

jwworth commented Dec 1, 2017

This is really cool; thank you for contributing! ❤️

We have stopped autoformatting files as described in #189 for now. Until we can run Elixir 1.6 on CI, something I anticipate working well when it's officially released in 2018, we will have no way to enforce these changes on future pull requests.

When we have that guarantee, we'll be only be changing a few files a time, to review and make sure they improve the code and don't break anything. Feel free to open a smaller (1-2 files or a directory) then.

For now we can merge the formatter config file, if you're interested in a smaller PR. Thanks!

@jwworth jwworth closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants