Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakages caused by packages missing bounds against regex-base-0.94.0 #243

Closed
3 tasks done
hvr opened this issue Sep 25, 2019 · 6 comments
Closed
3 tasks done

Breakages caused by packages missing bounds against regex-base-0.94.0 #243

hvr opened this issue Sep 25, 2019 · 6 comments

Comments

@hvr
Copy link
Contributor

hvr commented Sep 25, 2019

  • regex-tdfa
  • regex-pcre-builtin
  • regex-tdfa-text
@RyanGlScott
Copy link

RyanGlScott commented Sep 25, 2019

regex-pcre-builtin-0.94.4.8.8.35:

[1 of 6] Compiling Text.Regex.PCRE.Wrap ( dist/build/Text/Regex/PCRE/Wrap.hs, dist/build/Text/Regex/PCRE/Wrap.o )

Text/Regex/PCRE/Wrap.hsc:158:33: error:
    • Could not deduce (Control.Monad.Fail.MonadFail m)
        arising from a use of ‘makeRegexM’
      from the context: (RegexMaker Regex CompOption ExecOption source,
                         RegexContext Regex source1 target, Monad m)
        bound by the type signature for:
                   (=~~) :: forall source source1 target (m :: * -> *).
                            (RegexMaker Regex CompOption ExecOption source,
                             RegexContext Regex source1 target, Monad m) =>
                            source1 -> source -> m target
        at Text/Regex/PCRE/Wrap.hsc:(137,1)-(138,38)
      Possible fix:
        add (Control.Monad.Fail.MonadFail m) to the context of
          the type signature for:
            (=~~) :: forall source source1 target (m :: * -> *).
                     (RegexMaker Regex CompOption ExecOption source,
                      RegexContext Regex source1 target, Monad m) =>
                     source1 -> source -> m target
    • In a stmt of a 'do' block: (q :: Regex) <- makeRegexM r
      In the expression:
        do (q :: Regex) <- makeRegexM r
           matchM q x
      In an equation for ‘=~~’:
          (=~~) x r
            = do (q :: Regex) <- makeRegexM r
                 matchM q x
    |
158 | (=~~) x r = do (q :: Regex) <-  makeRegexM r
    |                                 ^^^^^^^^^^^^

See also audreyt/regex-pcre-builtin#7.

@quasicomputational
Copy link

Also biting regex-tdfa-text.

@phadej
Copy link
Member

phadej commented Sep 29, 2019

I made revisions for regex-tdfa-text. However, it looks like that users should migrate out of it.

@phadej
Copy link
Member

phadej commented Sep 29, 2019

regex-pcre-builtin reviewed

@hvr
Copy link
Contributor Author

hvr commented Sep 30, 2019

@phadej re those -text packages; I'm planning to add Text support to regex-pcre and regex-posix (see e.g. https://github.com/haskell-hvr/regex-pcre/commits/wip/text -- which I deferred to the next minor rls of regex-pcre due to some subtle bugs I couldn't get out in time)

@phadej
Copy link
Member

phadej commented Mar 26, 2020

I'm closing this. It has been quiet related to this general issue, so if there are some issues, they can be handled as regular ones.

@phadej phadej closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants