Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stack to tutorial docs #1177

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Conversation

jakequade
Copy link
Contributor

Follows up conversations around adding stack steps to the tutorial project documentation here

doc/tutorial/index.rst Outdated Show resolved Hide resolved
doc/tutorial/index.rst Show resolved Hide resolved
@alpmestan
Copy link
Contributor

Hello!

Thanks for stopping by and taking the time to prepare this patch! I left a review with a minor nitpick and a more "serious" problem, let us know if you need any help figuring it out or want more explanations.

@jakequade jakequade force-pushed the tutorial-stack branch 2 times, most recently from ad54af4 to f5f2911 Compare May 20, 2019 23:40
@alpmestan
Copy link
Contributor

@phadej We seem to be having CI failures (unrelated to the patch apparently) over here, Are those new? Transient?

@jakequade
Copy link
Contributor Author

bumping @phadej - seems to be an issue with a socket connection when travis tries to connect. Have tried pushing blank commits to force a retry, but no luck. Any ideas?

Thanks for your time with this :)

@arianvp
Copy link
Member

arianvp commented May 25, 2019

I have restarted the build. Lets see if we have more luck this time

@jakequade
Copy link
Contributor Author

@arianvp @phadej - it looks like a re-run of travis got rid of the CI hiccup. Are we good to merge this into the tutorial?

Thanks so much for your patience.

@arianvp arianvp merged commit d428993 into haskell-servant:master Jul 10, 2019
@arianvp
Copy link
Member

arianvp commented Jul 10, 2019

I squash merged it (to get rid of the bogus Travis commit). Thanks for the bump and thanks for the PR!

@jakequade jakequade deleted the tutorial-stack branch July 11, 2019 03:15
@jakequade
Copy link
Contributor Author

You're the best - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants