-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for application/x-www-form-urlencoded #13
Conversation
I'm going to wait till the dependent PR is merged to review |
Looks good, once #9 is merged in. We'll just have to rebase this PR to make sure travis gives us the go-ahead. Cheers! |
Good stuff. Mind adding a few more tests? Since the encoding/decoding is in-house, just checking inverse laws doesn't quite seem like enough. |
Changes Unknown when pulling 6ef48cf on anchor:form-urlencoded into * on haskell-servant:master*. |
Changes Unknown when pulling 1d378e6 on anchor:form-urlencoded into * on haskell-servant:master*. |
I just added 2 more roundtrip-tests using a different library.. The reason I don't use that library in the first place is
|
Changes Unknown when pulling 4f91a28 on anchor:form-urlencoded into * on haskell-servant:master*. |
Add support for application/x-www-form-urlencoded
Thanks! |
Use an `IORef` rather than a `MVar`.
This depends on #9. It support for url encoded request bodys. To use a custom type, There is these typeclasses: