Jkarni/content types

[jkarni]

Do not merge yet - QQ needs to fixed.

[jkarni]

I'm happy to merge this without QQ so all the downstream packages will start building against master, and then have the QQ as a separate PR. @alpmestan @tvh @christian-marie review?

[tvh]

Where should the instances for MimeRender and MimeUnreder live? I think they should live in a package that is used both by servant-server and servant-client. This could either mean a different package servant-instances, or just moving them in here. I prefer the latter. Related to this: I think there should be only types in here that are actually supported. Having something that sais XML is only confusing if there is no actual implementation backing it.

I also don't like upper bounds where they just guess if it will still work or not. With Stackage we have a powerful tool to catch those broken builds.

Apart from this I like how it looks.

[christian-marie]

I agree to all of these points ^^

I think servant-instances would be not so nice, I'd prefer just sticking them in servant.

As for XML, if it's not got instances it should be added to a servant-xml package with instances. Vice versa probably for anything that isn't JSON. Ideally, I'd like to ship "batteries included".

[christian-marie]

This is bending my mind a little, so this may not be 100% correct, but isn't this equivalent to:

fmap (\(a,b) -> (a, (cs $ show a, b)) amrs

Again, I didn't check the types. I may be wrong here.

[thsutton]

I've opened a pull request on servant-docs which updates it in line with the changes here.

https://github.com/haskell-servant/servant-docs/pull/12

[tvh]

There is one for servant-jquery as well.

https://github.com/haskell-servant/servant-jquery/pull/9

[coveralls]

Coverage decreased (-10.1%) to 48.48% when pulling 0453cc3 on jkarni/content-types into fb71eb8 on master.

[coveralls]

Coverage decreased (-10.1%) to 48.48% when pulling 0453cc3 on jkarni/content-types into fb71eb8 on master.

[coveralls]

Coverage decreased (-1.12%) to 57.46% when pulling 2714f34 on jkarni/content-types into fb71eb8 on master.

[coveralls]

Coverage decreased (-1.12%) to 57.46% when pulling 08528dc on jkarni/content-types into fb71eb8 on master.

[coveralls]

Coverage increased (+2.61%) to 61.19% when pulling 5470297 on jkarni/content-types into fb71eb8 on master.

[coveralls]

Coverage increased (+2.61%) to 61.19% when pulling 5470297 on jkarni/content-types into fb71eb8 on master.

[alpmestan]

Great work guys, this looks good to merge! Let the content-type-driven goodness spread =)

[coveralls]

Coverage increased (+2.61%) to 61.19% when pulling b02b67b on jkarni/content-types into fb71eb8 on master.

[jkarni]

Thanks a lot everyone for the reviews and ideas!