Add GHC 9.2 support #1482

brandon-leapyear · 2021-11-15T21:31:29Z

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

Related: #1475

akhesaCaro

Thanks for your contribution,

Here some additional tasks that mustn't be forgotten :

Be sure that the Nix can handle GHC 9.2
Add the parameter in the nix/README
Add a check with Cabal/GHC 9.2 on the CI (Only the stack check have been updated on the CI) - see https://github.com/haskell-servant/servant/blob/master/.github/workflows/master.yml
If needed, exclude GHC version of a Cookbook (and not commenting it please)

Are you okay with doing that?

Note : The PR (#1475) must be merged and this PR rebased before integrating it to the code base.

brandon-leapyear · 2021-11-28T22:55:10Z

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

I rebased and updated nix/README + github actions. I don't use Nix, so I won't be able to help with the Nix point, and I don't know what you mean by "Cookbook"

brandon-leapyear · 2021-11-28T23:25:42Z

servant/src/Servant/Links.hs

-    type MkLink (arr :> sub) _ = TypeError (PartialApplication HasLink arr)
+    type MkLink (arr :> sub) _ = TypeError (PartialApplication (HasLink :: * -> Constraint) arr)


This was added 2 weeks ago: 42b7d0e

GHC 9.2 is stricter about this:

GHC is stricter about checking for out-of-scope type variables on the right-hand sides of associated type family instances that are not bound on the left-hand side.

source

aab7e0d added another instance of this problem:

servant/servant-server/src/Servant/Server/Internal.hs

Line 824 in 7a770b5

type ServerT (arr :> sub) _ = TypeError (PartialApplication HasServer arr)

HasServer needs to become (HasServer :: * -> [*] -> Constraint) (and Constraint needs to be added to the import list).

ysangkok · 2022-01-20T15:26:33Z

@brandon-leapyear Looks like the 9.2 build is failing because of an old cabal-install version.

brandon-leapyear · 2022-01-20T17:09:33Z

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

@ysangkok I changed GHC 9.2 to run with Cabal 3.6, but I'm still getting errors. I don't use Cabal myself, can you help fix that?

akhesaCaro · 2022-01-21T10:14:19Z

Okay I will try on my side and keep you posted.

gdeest · 2022-01-24T12:46:12Z

I am not entirely making sense of the Cabal failure ; it seems to me that Cabal commits to a bound-to-fail plan because the constraints it tries to satisfy do not match pre-installed versions, but I am not entirely sure.

I am slightly concerned with the amount of allow-newer stanzas we have in the cabal.project files, especially for 9.2:

-- https://github.com/chordify/haskell-servant-pagination/pull/12
allow-newer: servant-pagination-2.2.2:servant
allow-newer: servant-pagination-2.2.2:servant-server

allow-newer: servant-js:servant

-- ghc 9
allow-newer: tdigest:base

-- ghc 9.2
allow-newer: basement:base
allow-newer: binary:bytestring
allow-newer: generics-sop:base
allow-newer: generics-sop:ghc-prim
allow-newer: generics-sop:template-haskell
allow-newer: http-media:base
allow-newer: lucid:base
allow-newer: memory:base
allow-newer: openssl-streams:bytestring
allow-newer: servant-js:base
allow-newer: servant-js:base-compat
allow-newer: servant-js:lens
allow-newer: servant-multipart:bytestring
allow-newer: servant-swagger:base-compat
allow-newer: singleton-bool:base
allow-newer: sop-core:base
allow-newer: swagger:base
allow-newer: swagger2:base
allow-newer: swagger2:base-compat-batteries
allow-newer: swagger2:bytestring
allow-newer: swagger2:lens
allow-newer: swagger2:template-haskell
allow-newer: swagger2:time

I am guessing we don't really have a choice because these libraries do not have 9.2-compatible releases yet ?

gdeest · 2022-01-25T08:11:00Z

I have managed to get past Cabal configure, but basement fails to build with GHC 9.2. We'll have to exclude some things from the 9.2 build.

tchoutri · 2022-01-25T08:23:56Z

Yes, the Hackage & Stackage folks have had some issues with basement and foundation, looks like the 9.2 support for these libraries will come one day™

brandon-leapyear · 2022-02-01T01:47:31Z

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

@gdeest in the future, can you let me know before you push changes to my fork? Thanks!

josephcsible · 2022-02-01T02:25:55Z

servant-server/src/Servant/Server/Internal.hs

@@ -821,7 +823,7 @@ instance (HasContextEntry context (NamedContext name subContext), HasServer subA
 -- Erroring instance for 'HasServer' when a combinator is not fully applied
 instance TypeError (PartialApplication HasServer arr) => HasServer ((arr :: a -> b) :> sub) context
  where
-    type ServerT (arr :> sub) _ = TypeError (PartialApplication HasServer arr)
+    type ServerT (arr :> sub) _ = TypeError (PartialApplication (HasServer :: Type -> Constraint) arr)


Shouldn't that be Type -> [Type] -> Constraint?

ysangkok · 2022-02-02T17:10:10Z

I think it is a bad idea to make the default stack.yaml on the master branch refer to unreleased versions of libraries (e.g. lens, foundation, etc). I see how it makes sense to do this for development purposes, though. But if this branch isn't supposed to be merged, maybe it would be clearer to mark it "Draft"? After dependencies are fixed or removed, it could be marked ready for review again.

stack.yaml

brandon-leapyear · 2022-02-02T18:45:23Z

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

I intended for the PR to be merged now. I wasn't sure how Stack is used in this project, e.g. if the standard build workflow is via Cabal, and the stack config is just there for reference. I've moved the Stack stuff into a new stack-ghc-9.2.yaml config.

I would prefer to not have a PR that I maintain open for an indefinite period of time. If you'd prefer to not merge any aspect of this PR at this time, feel free to close.

stack-ghc-9.2.yaml

cabal.project

servant-server/src/Servant/Server/Internal.hs

cabal.project

brandon-leapyear · 2022-02-24T17:56:38Z

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

@ysangkok can we get this merged anytime soon? I'd prefer to not be maintaining this long-term

ysangkok · 2022-03-09T19:06:22Z

@brandon-leapyear I am not a project maintainer, so it is not my decision to make. But I have submitted #1555 which achieves GHC 9.2 compatibility for a subset of packages that work on GHC 9.2, and marks the others as unbuildable. I prefer this approach due to how it doesn't legitimize unofficial forks of dependencies (as previously mentioned).

brandon-leapyear · 2022-03-09T19:14:20Z

✨ _**This is an old work account. Please reference @brandonchinn178 for all future communication**_ ✨

…

--- Fine by me. Can you link the same issue in your PR?

On Wed, Mar 9, 2022, 11:06 AM Janus Troelsen ***@***.***> wrote: @brandon-leapyear <https://github.com/brandon-leapyear> I am not a project maintainer, so it is not my decision to make. But I have submitted #1555 <#1555> which achieves GHC 9.2 compatibility for a subset of packages that work on GHC 9.2, and marks the others as unbuildable. I prefer this approach due to how it doesn't legitimize unofficial forks of dependencies (as previously mentioned <#1482 (comment)> ). — Reply to this email directly, view it on GitHub <#1482 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGUC75NJBNCEESHLHBBDVUTU7DZENANCNFSM5ICWIIJQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

maksbotan · 2022-03-21T13:16:19Z

@ysangkok @brandon-leapyear please check if this PR is still relevant after merge of #1555.

And thanks for your work!

akhesaCaro requested changes Nov 25, 2021

View reviewed changes

bergmark mentioned this pull request Nov 28, 2021

Initial GHC 9.2 bounds commercialhaskell/stackage#6318

Merged

brandon-leapyear commented Nov 28, 2021

View reviewed changes

tchoutri mentioned this pull request Dec 1, 2021

GHC 9.2.1 support #1491

Closed

georgefst mentioned this pull request Dec 28, 2021

Fails to build on ghc 9.2.1 #1496

Closed

brandon-leapyear requested a review from akhesaCaro January 11, 2022 19:57

josephcsible reviewed Feb 1, 2022

View reviewed changes

ysangkok requested changes Feb 2, 2022

View reviewed changes

stack.yaml Outdated Show resolved Hide resolved

ysangkok reviewed Feb 2, 2022

View reviewed changes

stack.yaml Outdated Show resolved Hide resolved

ysangkok requested changes Feb 5, 2022

View reviewed changes

cabal.project Outdated Show resolved Hide resolved

cabal.project Outdated Show resolved Hide resolved

dhess mentioned this pull request Feb 7, 2022

chore: Upgrade to GHC 9.2 hackworthltd/primer#244

Merged

shlevy reviewed Feb 7, 2022

View reviewed changes

servant-server/src/Servant/Server/Internal.hs Outdated Show resolved Hide resolved

srid mentioned this pull request Feb 7, 2022

GHC 9.2 support NorfairKing/sydtest#35

Closed

11 tasks

ysangkok reviewed Feb 13, 2022

View reviewed changes

cabal.project Outdated Show resolved Hide resolved

ysangkok reviewed Feb 15, 2022

View reviewed changes

cabal.project Outdated Show resolved Hide resolved

ysangkok reviewed Feb 15, 2022

View reviewed changes

cabal.project Outdated Show resolved Hide resolved

brandon-leapyear added 3 commits February 24, 2022 09:15

Bump stack resolver

44b1b08

Add GHC 9.2 support

1caefac

Update nix

d453626

brandon-leapyear added 2 commits February 24, 2022 09:18

Update cabal.project

2352201

Bump lucid support

4f77f12

ysangkok mentioned this pull request Mar 8, 2022

Allow GHC 9.2 for all packages #1555

Merged

brandon-leapyear closed this Mar 21, 2022

brandon-leapyear deleted the chinn/ghc-9.2 branch March 21, 2022 23:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GHC 9.2 support #1482

Add GHC 9.2 support #1482

brandon-leapyear commented Nov 15, 2021 •

edited

Loading

akhesaCaro left a comment •

edited

Loading

brandon-leapyear commented Nov 28, 2021 •

edited

Loading

brandon-leapyear Nov 28, 2021

josephcsible Feb 1, 2022

ysangkok commented Jan 20, 2022

brandon-leapyear commented Jan 20, 2022 •

edited

Loading

akhesaCaro commented Jan 21, 2022

gdeest commented Jan 24, 2022 •

edited

Loading

gdeest commented Jan 25, 2022

tchoutri commented Jan 25, 2022

brandon-leapyear commented Feb 1, 2022 •

edited

Loading

josephcsible Feb 1, 2022

ysangkok commented Feb 2, 2022

brandon-leapyear commented Feb 2, 2022 •

edited

Loading

brandon-leapyear commented Feb 24, 2022 •

edited

Loading

ysangkok commented Mar 9, 2022

brandon-leapyear commented Mar 9, 2022 via email •

edited

Loading

maksbotan commented Mar 21, 2022

		type MkLink (arr :> sub) _ = TypeError (PartialApplication HasLink arr)
		type MkLink (arr :> sub) _ = TypeError (PartialApplication (HasLink :: * -> Constraint) arr)

Add GHC 9.2 support #1482

Add GHC 9.2 support #1482

Conversation

brandon-leapyear commented Nov 15, 2021 • edited Loading

akhesaCaro left a comment • edited Loading

Choose a reason for hiding this comment

brandon-leapyear commented Nov 28, 2021 • edited Loading

brandon-leapyear Nov 28, 2021

Choose a reason for hiding this comment

josephcsible Feb 1, 2022

Choose a reason for hiding this comment

ysangkok commented Jan 20, 2022

brandon-leapyear commented Jan 20, 2022 • edited Loading

akhesaCaro commented Jan 21, 2022

gdeest commented Jan 24, 2022 • edited Loading

gdeest commented Jan 25, 2022

tchoutri commented Jan 25, 2022

brandon-leapyear commented Feb 1, 2022 • edited Loading

josephcsible Feb 1, 2022

Choose a reason for hiding this comment

ysangkok commented Feb 2, 2022

brandon-leapyear commented Feb 2, 2022 • edited Loading

brandon-leapyear commented Feb 24, 2022 • edited Loading

ysangkok commented Mar 9, 2022

brandon-leapyear commented Mar 9, 2022 via email • edited Loading

maksbotan commented Mar 21, 2022

brandon-leapyear commented Nov 15, 2021 •

edited

Loading

akhesaCaro left a comment •

edited

Loading

brandon-leapyear commented Nov 28, 2021 •

edited

Loading

brandon-leapyear commented Jan 20, 2022 •

edited

Loading

gdeest commented Jan 24, 2022 •

edited

Loading

brandon-leapyear commented Feb 1, 2022 •

edited

Loading

brandon-leapyear commented Feb 2, 2022 •

edited

Loading

brandon-leapyear commented Feb 24, 2022 •

edited

Loading

brandon-leapyear commented Mar 9, 2022 via email •

edited

Loading