Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated modules and functions #286

Merged
merged 4 commits into from
Sep 15, 2020

Conversation

Bodigrim
Copy link
Contributor

Closes #283.
As discussed, this PR cleans up all deprecated stuff except for boundedPrim, which was deprecated only a month ago.

@Bodigrim Bodigrim added this to the 0.11.0.0 milestone Sep 11, 2020
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I do have slight qualms about the Data.ByteString.Lazy.Builder modules since these have been properly deprecated only since August. Since it's so trivial and compatibility-problem-free to simply use Data.ByteString.Builder instead, I guess it's fine.

@fumieval
Copy link
Contributor

When I submitted #250, I searched through GitHub to check how many packages are affected, but I didn't see anything significant. Removing Data.ByteString.Lazy.Builder should be safe

@Bodigrim
Copy link
Contributor Author

Ping @hsyl20

@Bodigrim Bodigrim merged commit 444c475 into haskell:master Sep 15, 2020
@Bodigrim Bodigrim deleted the remove-deprecated branch September 15, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated methods and modules in the next major version.
3 participants