Attempt to avoid Haddock errors, make them nonfatal anyway #5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
typedrat
force-pushed
the
fix-haddock-error-handling
branch
from
87118d2
to
6c505be
Compare
typedrat
force-pushed
the
fix-haddock-error-handling
branch
from
6c505be
to
6e407de
Compare
typedrat
moved this from In Progress
to Needs Review
in Have new-build become build (GSOC2018)
|
Nice, let's get this into 2.4. |
23Skidoo
approved these changes
Jul 27, 2018
| @@ -969,6 +969,15 @@ dieOnBuildFailures verbosity plan buildOutcomes | |||
| maybeToList (InstallPlan.lookup plan pkgid) | |||
| ] | |||
|
|
|||
| fail' | |||
There was a problem hiding this comment.
Let's call this helper dieIfNotHaddockFailure or something similar.
typedrat
force-pushed
the
fix-haddock-error-handling
branch
from
d418022
to
7f59215
Compare
Haddock errors aren't fatal any more, but Cabal now knows not to invoke Haddock when there is no input for it to process.
typedrat
force-pushed
the
fix-haddock-error-handling
branch
from
7f59215
to
655daee
Compare
typedrat
moved this from Needs Review
to Done
in Have new-build become build (GSOC2018)
|
This seems to have broken #5977. Which is that you really do want haddock errors to be fatal when running |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5232.
Please include the following checklist in your PR: