Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to avoid Haddock errors, make them nonfatal anyway #5459

Merged
merged 2 commits into from Jul 27, 2018

Conversation

@typedrat
Copy link
Collaborator

typedrat commented Jul 27, 2018

Closes #5232.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.

@typedrat typedrat self-assigned this Jul 27, 2018

@typedrat typedrat force-pushed the typedrat:fix-haddock-error-handling branch from 87118d2 to 6c505be Jul 27, 2018

@typedrat typedrat force-pushed the typedrat:fix-haddock-error-handling branch from 6c505be to 6e407de Jul 27, 2018

@typedrat typedrat moved this from In Progress to Needs Review in Have new-build become build (GSOC2018) Jul 27, 2018

@23Skidoo 23Skidoo added this to the 2.4 milestone Jul 27, 2018

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Jul 27, 2018

Nice, let's get this into 2.4.

@23Skidoo
Copy link
Member

23Skidoo left a comment

Looks OK.

@@ -969,6 +969,15 @@ dieOnBuildFailures verbosity plan buildOutcomes
maybeToList (InstallPlan.lookup plan pkgid)
]

fail'

This comment has been minimized.

@23Skidoo

23Skidoo Jul 27, 2018

Member

Let's call this helper dieIfNotHaddockFailure or something similar.

@typedrat typedrat force-pushed the typedrat:fix-haddock-error-handling branch from d418022 to 7f59215 Jul 27, 2018

Haddock errors are no longer fatal, but prevent common ones anyway
Haddock errors aren't fatal any more, but Cabal now knows not to invoke Haddock when there is no input for it to process.

@typedrat typedrat force-pushed the typedrat:fix-haddock-error-handling branch from 7f59215 to 655daee Jul 27, 2018

@typedrat typedrat moved this from Needs Review to Done in Have new-build become build (GSOC2018) Jul 27, 2018

@typedrat typedrat merged commit 338c358 into haskell:master Jul 27, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.