Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5977 #6137

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Issue 5977 #6137

merged 2 commits into from
Jul 18, 2019

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jul 7, 2019

No description provided.

@phadej phadej requested a review from typedrat July 7, 2019 12:16
@phadej phadej mentioned this pull request Jul 7, 2019
Closed
4 tasks
@phadej
Copy link
Collaborator Author

phadej commented Jul 7, 2019

Added test to #6136. It fails in master, doesn't fail with Sandy's patch.

I hope this doesn't regress #5459 fixes.

typedrat
typedrat approved these changes Jul 18, 2019
View reviewed changes
Copy link
Collaborator

@typedrat typedrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is code that I had half-written but it exists fully here.

@typedrat
Copy link
Collaborator

Was gonna merge, but needs changelog note.

@typedrat
Copy link
Collaborator

Also, glad to be out of the hospital. :)

@phadej phadej merged commit 0d2d9ca into master Jul 18, 2019
@phadej phadej deleted the issue-5977 branch July 18, 2019 14:18
@phadej
Copy link
Collaborator Author

phadej commented Jul 18, 2019

Will add changelog entry separately.

@phadej phadej mentioned this pull request Jul 20, 2019
Closed
23Skidoo pushed a commit that referenced this pull request Aug 27, 2019
@phadej @23Skidoo
Merge pull request #6137 from haskell/issue-5977
d4d224e 
Issue 5977

(cherry picked from commit 0d2d9ca)
@23Skidoo
Copy link
Member

Cherry-picked to 3.0.

@ag-eitilt ag-eitilt mentioned this pull request Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typedrat typedrat typedrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phadej @typedrat @23Skidoo @isovector