-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ordNub for extra stanzas #8499
ordNub for extra stanzas #8499
Conversation
|
||
-- | Add extra source dir for generated modules. | ||
addSrcDir :: BuildInfo -> FilePath -> BuildInfo | ||
addSrcDir bi extra = bi { hsSourceDirs = new } | ||
where new = Set.toList $ old `Set.union` ex | ||
old = Set.fromList $ hsSourceDirs bi | ||
ex = Set.fromList [unsafeMakeSymbolicPath extra] -- TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to the TODO
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got lost, but I'm not sure what it meant to begin with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, neither do I, unfortunately. I hoped you fixed it somehow :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What it meant I have a guess: maybe the author of TODO wished there was no "unsafe"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Given how long it stayed there, let's not worry too much about unsafeMakeSymbolicPath
.
@gbaz: let's merge? |
* ordNub for extra stanzas * changelong * Update pr-8499 Co-authored-by: Gershom Bazerman <gershom@arista.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Resolves #8458
Also moves the other uses of set-based nubbing in that file to ordNub, which should hopefully be a strict improvement.