ordNub for extra stanzas #8499
Merged
ordNub for extra stanzas #8499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
reviewed
Sep 29, 2022
|
|
||
| -- | Add extra source dir for generated modules. | ||
| addSrcDir :: BuildInfo -> FilePath -> BuildInfo | ||
| addSrcDir bi extra = bi { hsSourceDirs = new } | ||
| where new = Set.toList $ old `Set.union` ex | ||
| old = Set.fromList $ hsSourceDirs bi | ||
| ex = Set.fromList [unsafeMakeSymbolicPath extra] -- TODO |
There was a problem hiding this comment.
What happened to the TODO?
There was a problem hiding this comment.
got lost, but I'm not sure what it meant to begin with?
There was a problem hiding this comment.
yeah, neither do I, unfortunately. I hoped you fixed it somehow :D
There was a problem hiding this comment.
What it meant I have a guess: maybe the author of TODO wished there was no "unsafe"?
ulysses4ever
approved these changes
Oct 1, 2022
Mikolaj
approved these changes
Oct 17, 2022
|
@gbaz: let's merge? |
mergify
bot
added
the
merge delay passed
alexbiehl
pushed a commit
to alexbiehl/cabal
that referenced
this pull request
Dec 15, 2022
* ordNub for extra stanzas * changelong * Update pr-8499 Co-authored-by: Gershom Bazerman <gershom@arista.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8458
Also moves the other uses of set-based nubbing in that file to ordNub, which should hopefully be a strict improvement.