Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the drawing functions of Data.Tree #49

Closed
jonasc opened this issue Aug 7, 2014 · 2 comments
Closed

Generalize the drawing functions of Data.Tree #49

jonasc opened this issue Aug 7, 2014 · 2 comments

Comments

@jonasc
Copy link

jonasc commented Aug 7, 2014

Hi,

I wanted to use drawTree on a Tree Int but it does not work for the drawing functions only accept Tree String instances. In my opinion this is too strict and can easily be generalized to Show s => Tree s. I made that change in a fork here: jonasc@e650dda
I would be happy to create a pull request for this commit.

@foxik
Copy link
Contributor

foxik commented Aug 8, 2014

@jonasc Good idea.

There needs to be no discussion about this change, it is a simple generalization, consistent with showTree and showTreeWith functions from {,Int}{Map,Set}.

Please create the pull request.

@foxik
Copy link
Contributor

foxik commented Oct 19, 2014

Merged to development branch quite a while ago.

@foxik foxik closed this as completed Oct 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants