Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recursion tracking from TacticState #1453

Merged
merged 6 commits into from Mar 1, 2021

Conversation

isovector
Copy link
Collaborator

As a followup to #1449, this PR removes the remnants of data that should be in the tactic extract, but was stuck in the state. The core of it is a weird combinator peek that @TOTBWF came up with.

Also, it was becoming tiresome to pack and unpack Synthesizeds all the time. So I joined the century of the fruitbat and am now using lenses.

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the generic lenses

@isovector isovector added the merge me Label to trigger pull request merge label Feb 27, 2021
@mergify mergify bot merged commit 76dadaa into haskell:master Mar 1, 2021
@isovector isovector deleted the no-recursion branch March 1, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants