Add test data files to extra-source-files #1605
Conversation
haskell-language-server.cabal
Outdated
| -- eval plugin test data is used in the test suite | ||
| plugins/hls-eval-plugin/test/testdata/*.yaml | ||
| plugins/hls-eval-plugin/test/testdata/*.hs | ||
| plugins/hls-eval-plugin/test/testdata/*.hs.expected |
There was a problem hiding this comment.
This is kinda hacky to me... Let's move eval plugin's tests into its own package, like Sandy did in #1425
There was a problem hiding this comment.
Agree but it deserves its own pr? This one only makes the hack more evident 😃
There was a problem hiding this comment.
@berberman we can wait for such pr and rebase, if it is about to be done, of course
There was a problem hiding this comment.
I'm working on this. I think we need extract hls-test-utils to a standalone package, with some test framework stuffs re-exported, so that tests extracted from HLS could reuse these code.
There was a problem hiding this comment.
I will remove eval test data files and wait for #1606
|
|
||
| library | ||
| exposed-modules: Ide.Plugin.Brittany | ||
| hs-source-dirs: src | ||
| build-depends: base | ||
| , brittany >= 0.13.1.0 | ||
| build-depends: base >=4.12 && <5 |
There was a problem hiding this comment.
I copied it from the main package so I would keep it for consistency, this way we will accept base > 4.12 && < 5, not sure if it is a good thing though.
But I would change it in another pr, if you don't mind.
There was a problem hiding this comment.
Sure, the plan sounds good to me
cabal check